From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bU1JFe60cmHJdwAAWB0awg (envelope-from ) for ; Fri, 22 Oct 2021 08:56:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 478EC1F0BD; Fri, 22 Oct 2021 08:56:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8A8FD1ECEB for ; Fri, 22 Oct 2021 08:56:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 406A8385781B for ; Fri, 22 Oct 2021 12:56:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 406A8385781B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634907373; bh=4q8AozZO7UoKgiabvKlgGlyZlLCRV8TVKTghU9/7tVc=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=W5sd055lPU1q8ZvbvCsow7c9nL1W4fVWxCqw/73xl38vyOVT2RBO+0YzqjNdTMxpP VMVM7Nk2HAqouBmh7FH1thIvCtJtFwXE/Rp3PLxyDOoNKVIYC3dXm0t1q8Z6lgTgqJ bsB5pf6rIGwMiqNaLBajDZnTUFKWHVovo+Fx6MLQ= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 12AEF3858416 for ; Fri, 22 Oct 2021 12:55:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 12AEF3858416 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 19MCtnGn032746 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Oct 2021 08:55:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 19MCtnGn032746 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 58F4E1ECEB; Fri, 22 Oct 2021 08:55:49 -0400 (EDT) Message-ID: <087bd7be-bb4e-aca7-b040-169be3632114@polymtl.ca> Date: Fri, 22 Oct 2021 08:55:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH][gdb/testsuite] Fix FAILs in gdb.mi/mi-breakpoint-changed.exp Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20211005144645.GA29297@delia> In-Reply-To: <20211005144645.GA29297@delia> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 22 Oct 2021 12:55:49 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-10-05 10:46, Tom de Vries via Gdb-patches wrote: > Hi, > > Since commit e36788d1354 "[gdb/testsuite] Fix handling of nr_args < 3 in > mi_gdb_test" we run into: > ... > PASS: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: mi runto main > Expecting: ^(-break-insert -f pendfunc1[^M > ]+)?((&.*)*.*~"Breakpoint 2 at.*\\n".*=breakpoint-created,\ > bkpt=\{number="2",type="breakpoint".*\}.*\n\^done[^M > ]+[(]gdb[)] ^M > [ ]*) > -break-insert -f pendfunc1^M > ^done,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",\ > addr="0x00007ffff7bd559e",func="pendfunc1",\ > file="gdb/testsuite/gdb.mi/pendshr1.c",\ > fullname="gdb/testsuite/gdb.mi/pendshr1.c",line="21",thread-groups=["i1"],\ > times="0",original-location="pendfunc1"}^M > (gdb) ^M > FAIL: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ > -break-insert -f pendfunc1 (unexpected output) > ... > > The regexp expects a breakpoint-created event, but that's actually suppressed > by the command: > ... > DEF_MI_CMD_MI_1 ("break-insert", mi_cmd_break_insert, > &mi_suppress_notification.breakpoint), > ... > > Fix this by updating the regexp. > > Likewise for the following: > ... > PASS: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ > -break-insert -f pendfunc1 > Expecting: ^(-break-enable count 1 2[^M > ]+)?(=breakpoint-modified,\ > bkpt=\{number="2",type="breakpoint",disp="dis",enabled="y".*\}.*\n\^done[^M > ]+[(]gdb[)] ^M > [ ]*) > -break-enable count 1 2^M > ^done^M > (gdb) ^M > FAIL: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ > -break-enable count 1 2 (unexpected out\ > put) > ... > > Tested on x86_64-linux. > > Any comments? So, the test used to wrongfully pass because mi_gdb_test was broken, and fixing mi_gdb_test exposed that the test is wrong? If so, this looks good to me. Simon