From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16478 invoked by alias); 9 Oct 2016 17:30:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16213 invoked by uid 89); 9 Oct 2016 17:30:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:365 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Oct 2016 17:30:04 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6679981F07; Sun, 9 Oct 2016 17:30:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u99HU1gw012317; Sun, 9 Oct 2016 13:30:02 -0400 Subject: Re: [RFA 16/22] Use std::vector in elf_read_minimal_symbols To: Tom Tromey , gdb-patches@sourceware.org References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-17-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <086dc924-f9c6-e5e0-5518-bdc5bee3523d@redhat.com> Date: Sun, 09 Oct 2016 17:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474949330-4307-17-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00202.txt.bz2 On 09/27/2016 05:08 AM, Tom Tromey wrote: > This changes elf_read_minimal_symbols to use std::vector rather than > an explicit allocation. This removes a cleanup. LGTM, though same comment about unique_ptr applies. (I'll stop saying that in follow up patches, even it would apply). Thanks, Pedro Alves