From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id A2F2C386101A for ; Tue, 14 Jul 2020 14:30:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A2F2C386101A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 572FFAEC9; Tue, 14 Jul 2020 14:30:51 +0000 (UTC) Subject: Re: [PATCH] Require GNU make 3.82 To: Alan Hayward , Eli Zaretskii Cc: "gdb-patches@sourceware.org" , nd References: <20190715101124.77677-1-alan.hayward@arm.com> <83v9vzyih8.fsf@gnu.org> <1298B553-A75A-4D06-9AC4-4F924B045C16@arm.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <0803f7e7-8564-c079-e1ee-e9fb3497a319@suse.de> Date: Tue, 14 Jul 2020 16:30:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1298B553-A75A-4D06-9AC4-4F924B045C16@arm.com> Content-Type: multipart/mixed; boundary="------------F365F474E32E69016E458D5C" Content-Language: en-US X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 14:30:51 -0000 This is a multi-part message in MIME format. --------------F365F474E32E69016E458D5C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 7/18/19 12:57 PM, Alan Hayward wrote: > > >> On 18 Jul 2019, at 07:17, Eli Zaretskii wrote: >> >>> From: Alan Hayward >>> CC: nd , Alan Hayward >>> Date: Mon, 15 Jul 2019 10:11:29 +0000 >>> >>> Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be. >> >> Which feature of Make 3.82 and later is required to successfully >> build gdbserver? >> > > It’s not a specific feature in 3.82 that is required. > > It looks like it is a bug in 3.81. The GDB makefile isn’t doing anything special > and everything works using 3.82 upwards. > > Rewriting the makefile to work around the issue is probably going to be a little > messy. > This patch (on top of gdb 9.1) works around the issue for make 3.81. Build with make 3.81 and make 4.2.1 on x86_64-linux. Thanks, - Tom --------------F365F474E32E69016E458D5C Content-Type: text/x-patch; charset=UTF-8; name="0001-gdbserver-Fix-build-with-make-3.81.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-gdbserver-Fix-build-with-make-3.81.patch" [gdbserver] Fix build with make 3.81 --- gdb/gdbserver/Makefile.in | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in index 16a9f2fd38..687bee2658 100644 --- a/gdb/gdbserver/Makefile.in +++ b/gdb/gdbserver/Makefile.in @@ -580,9 +580,22 @@ ax.o: ax.c $(COMPILE) $(WARN_CFLAGS_NO_FORMAT) $< $(POSTCOMPILE) +ifeq ($(WORKAROUND_ALLOC_IPA),) +ifeq ($(MAKE_VERSION),3.81) +WORKAROUND_ALLOC_IPA = 1 +else +WORKAROUND_ALLOC_IPA = 0 +endif +endif + +ifeq ($(WORKAROUND_ALLOC_IPA),0) alloc-ipa.o: ../alloc.c $(IPAGENT_COMPILE) $(WARN_CFLAGS_NO_FORMAT) $< $(POSTCOMPILE) +else +alloc-ipa.o: ../alloc.c + @$(MAKE) $(FLAGS_TO_PASS) WORKAROUND_ALLOC_IPA=0 alloc-ipa.o +endif # Rules for objects that go in the in-process agent. --------------F365F474E32E69016E458D5C--