From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100480 invoked by alias); 27 Jun 2017 17:18:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100402 invoked by uid 89); 27 Jun 2017 17:18:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=screw, xxx X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 17:18:20 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 473577A167; Tue, 27 Jun 2017 17:18:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 473577A167 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 473577A167 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E95386E0A; Tue, 27 Jun 2017 17:18:18 +0000 (UTC) Subject: Re: [RFA 08/10] Move some code later in backtrace_command_1 To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-9-tom@tromey.com> From: Pedro Alves Message-ID: <07cbdccd-4274-0551-244f-856c062dab93@redhat.com> Date: Tue, 27 Jun 2017 17:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-9-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00741.txt.bz2 On 04/25/2017 08:41 PM, Tom Tromey wrote: > PR backtrace/15584 notes that some code in backtrace_command_1 is not > useful when frame filters are in use. Doesn't the "info verbose on" bit affect frame filters too? Particularly the: "Need to do this in a separate pass so that "Reading in symbols for xxx" messages don't screw up the appearance of the backtrace." ... remark. Not sure I fully understand whether that "info verbose" code makes sense nowadays, though. It doesn't seem to be documented in the manual. In any case, if you need that, then I guess it'd be done somewhere inside the frame filters code, I suppose? With that in mind, this LGTM. Thanks, Pedro Alves