From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18857 invoked by alias); 16 Oct 2003 18:46:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18850 invoked from network); 16 Oct 2003 18:46:42 -0000 Received: from unknown (HELO hub.ott.qnx.com) (209.226.137.76) by sources.redhat.com with SMTP; 16 Oct 2003 18:46:42 -0000 Received: from smtp.ott.qnx.com (smtp.ott.qnx.com [10.0.2.158]) by hub.ott.qnx.com (8.9.3/8.9.3) with ESMTP id OAA03692; Thu, 16 Oct 2003 14:42:36 -0400 Received: from catdog ([10.4.2.2]) by smtp.ott.qnx.com (8.8.8/8.6.12) with SMTP id OAA06241; Thu, 16 Oct 2003 14:46:42 -0400 Message-ID: <07b401c39415$f4dc7ae0$0202040a@catdog> From: "Kris Warkentin" To: "Elena Zannoni" Cc: References: <16240.46973.557418.422147@localhost.redhat.com> <002601c3823a$209cd910$6400a8c0@dash> Subject: Re: [Patch] fix for PR:1291 (Ping Corinna) Date: Thu, 16 Oct 2003 18:46:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 X-SW-Source: 2003-10/txt/msg00554.txt.bz2 Howdy all, Finally got around to building a head branch gdb with Corinna's sh4 work. Excellent job. The backtrace works perfectly now and renders my patch redundant. Someone can probably put this PR to fixed-test. cheers, Kris ----- Original Message ----- From: "Kris Warkentin" To: "Elena Zannoni" Cc: Sent: Tuesday, September 23, 2003 9:21 PM Subject: Re: [Patch] fix for PR:1291 > > kewarken writes: > > > Credit to inaba@src.ricoh.co.jp for his original find and patch and to > > > Colin Burgess for noting the differences between gcc 2 and 3. > > > > > > ChangeLog: > > > > > > 2003-09-16 Kris Warkentin > > > > > > * sh-tdep.c: Properly detect frame prologues for functions with > > > more than 256 bytes of local variables. > > > > You should give credit to these folks in the changelog entry. > > Certainly. > > > I wonder if this can be captured in a test case? How does your change > > interacts with Corinna's rewrite? > > I'll take a look at it when I have some more time next week. The test case > is very simple so I can easily check to see if Corinna's stuff fixes it. > Unfortunately my available gdb cycles have been extremely low lately since > we have a lot of critical internal stuff that I've been grabbed for. > > cheers, > > Kris > >