From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8554 invoked by alias); 24 Oct 2003 14:27:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8545 invoked from network); 24 Oct 2003 14:27:01 -0000 Received: from unknown (HELO hub.ott.qnx.com) (209.226.137.76) by sources.redhat.com with SMTP; 24 Oct 2003 14:27:01 -0000 Received: from smtp.ott.qnx.com (smtp.ott.qnx.com [10.0.2.158]) by hub.ott.qnx.com (8.9.3/8.9.3) with ESMTP id KAA04864; Fri, 24 Oct 2003 10:22:09 -0400 Received: from catdog ([10.4.2.2]) by smtp.ott.qnx.com (8.8.8/8.6.12) with SMTP id KAA19557; Fri, 24 Oct 2003 10:27:00 -0400 Message-ID: <07af01c39a3b$07bcaf60$0202040a@catdog> From: "Kris Warkentin" To: "Elena Zannoni" Cc: "Elena Zannoni" , References: <16240.46973.557418.422147@localhost.redhat.com><002601c3823a$209cd910$6400a8c0@dash><07b401c39415$f4dc7ae0$0202040a@catdog> <16281.9791.565787.650032@localhost.redhat.com> Subject: Re: [Patch] fix for PR:1291 (Ping Corinna) Date: Fri, 24 Oct 2003 14:27:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 X-SW-Source: 2003-10/txt/msg00726.txt.bz2 Here is what I used. Do I need to do something to formally put this in or is this sufficient? cheers, Kris #include main() { printf("hello world\n"); sub1(); sub2(); } sub1() { int buf[64]; } sub2() { int buf[65]; } break sub1 break sub2 run backtrace continue backtrace Failure: Breakpoint 1, sub1 () at sh-bt.c:13 13 } (gdb) bt #0 sub1 () at sh-bt.c:13 #1 0x0804047c in main () at sh-bt.c:6 #2 0x08040432 in t2 () (gdb) c Continuing. Breakpoint 2, sub2 () at sh-bt.c:18 18 } (gdb) bt #0 sub2 () at sh-bt.c:18 (gdb) Success: Breakpoint 1, sub1 () at sh-bt.c:13 13 } (gdb) bt #0 sub1 () at sh-bt.c:13 #1 0x0804047c in main () at sh-bt.c:6 (gdb) c Continuing. Breakpoint 2, sub2 () at sh-bt.c:18 18 } (gdb) bt #0 sub2 () at sh-bt.c:18 #1 0x08040484 in main () at sh-bt.c:7 (gdb) ----- Original Message ----- From: "Elena Zannoni" To: "Kris Warkentin" Cc: "Elena Zannoni" ; Sent: Friday, October 24, 2003 9:16 AM Subject: Re: [Patch] fix for PR:1291 (Ping Corinna) > Kris Warkentin writes: > > Howdy all, > > > > Finally got around to building a head branch gdb with Corinna's sh4 work. > > Excellent job. The backtrace works perfectly now and renders my patch > > redundant. Someone can probably put this PR to fixed-test. > > > > Could you still come up with a small testcase to be added to gdb.arch? > > elena > > > > cheers, > > > > Kris > > > > ----- Original Message ----- > > From: "Kris Warkentin" > > To: "Elena Zannoni" > > Cc: > > Sent: Tuesday, September 23, 2003 9:21 PM > > Subject: Re: [Patch] fix for PR:1291 > > > > > > > > kewarken writes: > > > > > Credit to inaba@src.ricoh.co.jp for his original find and patch and > > to > > > > > Colin Burgess for noting the differences between gcc 2 and 3. > > > > > > > > > > ChangeLog: > > > > > > > > > > 2003-09-16 Kris Warkentin > > > > > > > > > > * sh-tdep.c: Properly detect frame prologues for functions with > > > > > more than 256 bytes of local variables. > > > > > > > > You should give credit to these folks in the changelog entry. > > > > > > Certainly. > > > > > > > I wonder if this can be captured in a test case? How does your change > > > > interacts with Corinna's rewrite? > > > > > > I'll take a look at it when I have some more time next week. The test > > case > > > is very simple so I can easily check to see if Corinna's stuff fixes it. > > > Unfortunately my available gdb cycles have been extremely low lately since > > > we have a lot of critical internal stuff that I've been grabbed for. > > > > > > cheers, > > > > > > Kris > > > > > > > > >