From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 65C28385E014 for ; Fri, 27 Mar 2020 12:27:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 65C28385E014 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42d.google.com with SMTP id h15so11156134wrx.9 for ; Fri, 27 Mar 2020 05:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=yvhKfuJd3YXod9xiyT0OxOgdymygY26CZAtkcGI11SA=; b=Dwx7UftxdYQXBemx/LV98z7ug7SWQKrwPceD9KkmLAy9V2GNziJwSMZpo8M72G+aZS kxz1w8hPDlkXwlTYjFjtXBmlgZjP4U/8ozUNrxtcppyyJj2VU3zyuAvH6IyTbtQbAEE7 Mv5EEBv4BGH8OiauCFKT0mX4toTizXkmzkrnNo41J7cFifR/TxgtGM9YlQGxQfRBmEh7 1ed7xG/TEJfFxQ3nhz8aletyRoB8xPZVE3wceyA72uGNdQ593igrUlk7iqE7Bp+Mk4Iv lZ3oSMEGMMaLTu9Yf607LnMZGBCAXd3BgD9aLHZJNTiFHXrGLoKZ8/1dNKnq3aE1Dene Fp8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=yvhKfuJd3YXod9xiyT0OxOgdymygY26CZAtkcGI11SA=; b=jaTcWQjXYg/0d6M5Qc2iVitig0EIPEONutbVg1WW6Zywdnx3AX0ZdiWYEQ502FCf0l XWyJgN+3rW+EHpcK+XCWXVGoT9JEMMEOaLdPexAC/q9sFV1droX16I7lOq98hCrBe9w0 ix84NE8+OdQ1o/WpEEhpQltr66JL4e2+VR2QW94q0d5sYD8WJ1SgrHgR8sNKppFCMCgF JTi62KtSgD7D+1GDz5rCKuT2Axyf7sgl2s7Pryc1e4THtjj6vGieRRC6g4n3mGMBGy3L Afw4lWu881ILR1NvWVBdNoYjIgZbFH+Ou4UaYPnwXa9GBY84Glx9OEUl6O7wFHPgaAFK BbtQ== X-Gm-Message-State: ANhLgQ0oofeeHP1fmN4TG33Y6yMVDVFBEHn+bMI5Y4nx0KgldA2bff3V RWkvlWi2pJ7UxUYUXQtEMKyzFH/g7N0= X-Google-Smtp-Source: ADFU+vt77C9Ilg5DaaofAdMFs3PQOJydOqOS4ratLG6O/dRabuIXYIH7GBvHKlL9khVrMaUHm7qGZA== X-Received: by 2002:a5d:630e:: with SMTP id i14mr14815219wru.260.1585312036365; Fri, 27 Mar 2020 05:27:16 -0700 (PDT) Received: from localhost (host86-186-80-207.range86-186.btcentralplus.com. [86.186.80.207]) by smtp.gmail.com with ESMTPSA id g3sm8603490wrm.66.2020.03.27.05.27.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Mar 2020 05:27:15 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Simon Marchi , Joel Brobecker , Andrew Burgess Subject: [PATCH 1/2] gdbsupport: Resolve shellcheck issues in create-version.sh script Date: Fri, 27 Mar 2020 12:27:11 +0000 Message-Id: <0784fb919936e8e5afa466c7597c37c574a44bb9.1585311874.git.andrew.burgess@embecosm.com> X-Mailer: git-send-email 2.14.5 In-Reply-To: References: In-Reply-To: References: <47128465-bbae-6241-6b04-929163f15229@simark.ca> X-Spam-Status: No, score=-26.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2020 12:27:18 -0000 Run shellcheck (version 0.4.7) on the create-version.sh script, and resolve the issues it highlighter - they all seemed reasonable. gdbsupport/ChangeLog: * create-version.sh: Resolve issues highlighted by shellcheck. --- gdbsupport/ChangeLog | 4 ++++ gdbsupport/create-version.sh | 18 ++++++++++-------- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/gdbsupport/create-version.sh b/gdbsupport/create-version.sh index 81d6dbf8c1f..6135d219d94 100755 --- a/gdbsupport/create-version.sh +++ b/gdbsupport/create-version.sh @@ -27,12 +27,14 @@ host_alias="$2" target_alias="$3" output="$4" -rm -f version.c-tmp $output version.tmp -date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$/\1/p' $srcdir/../bfd/version.h` -sed -e "s/DATE/$date/" < $srcdir/version.in > version.tmp -echo '#include "gdbsupport/version.h"' >> version.c-tmp -echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp -echo 'const char host_name[] = "'"$host_alias"'";' >> version.c-tmp -echo 'const char target_name[] = "'"$target_alias"'";' >> version.c-tmp -mv version.c-tmp $output +rm -f version.c-tmp "$output" version.tmp +date=$(sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$/\1/p' "$srcdir/../bfd/version.h") +sed -e "s/DATE/$date/" < "$srcdir/version.in" > version.tmp +{ + echo '#include "gdbsupport/version.h"' + echo 'const char version[] = "'"$(sed q version.tmp)"'";' + echo 'const char host_name[] = "'"$host_alias"'";' + echo 'const char target_name[] = "'"$target_alias"'";' +} >> version.c-tmp +mv version.c-tmp "$output" rm -f version.tmp -- 2.14.5