From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] gdb: ignore -Wregister instead of -Wdeprecated-register
Date: Mon, 11 Mar 2024 13:51:11 -0400 [thread overview]
Message-ID: <0780826d-4649-45e8-b056-dcae2a513bb1@efficios.com> (raw)
In-Reply-To: <878r2opski.fsf@tromey.com>
On 3/11/24 13:49, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> In ada-lex.l, we already use `DIAGNOSTIC_IGNORE_DEPRECATED_REGISTER`,
> Simon> which for Clang translates to ignoring `-Wdeprecated-register` [1]. I think
> Simon> that was produced when compiling as C++11, but now that we always compile as
> Simon> C++17, Clang produces a `-Wregister` error [2].
>
> Can we just '#define register' in this file or somewhere nearby?
We probably can, but ignoring the diagnostic seems safer and less hacky
to me.
Simon
next prev parent reply other threads:[~2024-03-11 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 16:06 Simon Marchi
2024-03-11 17:49 ` Tom Tromey
2024-03-11 17:51 ` Simon Marchi [this message]
2024-04-06 3:26 ` Simon Marchi
2024-04-06 14:40 ` Tom Tromey
2024-04-08 2:58 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0780826d-4649-45e8-b056-dcae2a513bb1@efficios.com \
--to=simon.marchi@efficios.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox