From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id c2NuNYrhjl/RbAAAWB0awg (envelope-from ) for ; Tue, 20 Oct 2020 09:09:30 -0400 Received: by simark.ca (Postfix, from userid 112) id CC5BD1EFC1; Tue, 20 Oct 2020 09:09:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 373881EF48 for ; Tue, 20 Oct 2020 09:09:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE2FF3857C7B; Tue, 20 Oct 2020 13:09:29 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CA6CC3857C7B for ; Tue, 20 Oct 2020 13:09:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CA6CC3857C7B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 305F71EF48; Tue, 20 Oct 2020 09:09:27 -0400 (EDT) Subject: Re: [PING][PING] Added x86_64 stub for debugging embedded systems running on Intel x86_64 processor architecture. To: "Battig, Caleb" , "gdb-patches@sourceware.org" References: <84cb0009-cbd5-975a-cdaf-ac8cd77686aa@simark.ca> From: Simon Marchi Message-ID: <074c171f-c4c0-d50f-0b51-c2d3e7e79ad3@simark.ca> Date: Tue, 20 Oct 2020 09:09:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Lovett, Stuart" , "Peikes, Wendy" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-10-19 6:23 p.m., Battig, Caleb wrote: > Simon, > > Thanks so much for looking into this. This is a significant addition to GDB that has the potential to help a lot of developers. > > I've made some formatting changes. See the attached patch. I'm not sure what you meant by your comment on whitespace and indentation, but I made all the other changes. > > Thanks, For example, if a line is indented by 18 columns, that means you'll have two tabs (worth 16 columns) followed by two spaces (for a total of 18 columns). You can find the faulty lines using: $ grep -E '^\t* ' x86_64-stub.c Can you please send your patch using git-send-email? It's not convenient to send in-line comments for a patch sent as attachment. "if" blocks should be formatted like this: if (something) { .. } "if" blocks that contain a single line don't need braces. The exception is if you ou have nested "if" blocks, the outer ones need to have braces: if (something) printf ("Something"); but: if (something) { if (something_else) printf ("Something 1"); } else printf ("Something 2"); Thanks, Simon