Re: [ PATCH 1/3] Fix GDB reverse execution behavior

Luis Machado
2023-11-29T16:38:44Z

On 11/29/23 16:30, Carl Love wrote:
> Luis:
>
> On Wed, 2023-11-29 at 11:44 +0000, Luis Machado wrote:
>>> + } else {
>>> + error "Option gcolumn-info option not supported by
>>> compiler."
>>
>> s/Option gcolumn-info option/Option gcolumn-info
> fixed
>>
>>> + }
>>> +
>>> + } elseif { $opt == "no-column-info" } {
>>> + if {[test_compiler_info {gcc-*}]} {
>>> + if {[test_compiler_info {gcc-[1-6]-*}]} {
>>> + # In this case, don't add the compile line option
>>> and
>>> + # the result will be the same as using no-column-
>>> info
>>> + # on a version that supports the option.
>>> + warning "gdb_compile option no-column-info not
>>> supported, ignoring."
>>> + } else {
>>> + lappend new_options "additional_flags=-gno-
>>> column-info"
>>> + }
>>> +
>>> + } elseif {[test_compiler_info {clang-*}]} {
>>> + lappend new_options "additional_flags=-gno-column-
>>> info"
>>> +
>>> + } else {
>>> + error "Option gno-column-info option not supported by
>>> compiler."
>>
>> s/Option gno-column-info option/Option gno-column-info
> fixed
>
> I made the fixes to the patches. The changes are fairly trivial so let
> s see if anyone else has any comments to add before sending out another
> version.
>
> Thanks for reviewing and testing.
>
> Carl
>

For what's worth, I don't think it needs another version for these small fixes.