Re: [ PATCH 0/3] Fix GDB reverse execution behavior

Luis Machado
2023-12-11T14:41:25Z

Hi Carl,

On 11/30/23 15:43, Luis Machado wrote:
> On 11/30/23 15:39, Carl Love wrote:
>> Guinevere:
>>
>> On Thu, 2023-11-30 at 12:36 +0100, Guinevere Larsen wrote:
>>> On a side note, b4 didn't really like this series and I'm not sure
>>> why.
>>> My guess is that all 3 patches have the same email subject, but it
>>> may
>>> also be that I needed --3way when using git am. Either way, just
>>> mentioning to gather knowledge on what b4 likes or doesn't like.
>>
>>
>> I am not familiar with b4. I just did a Google search and found a
>> description of it at:
>>
>> https://people.kernel.org/monsieuricon/introducing-b4-and-patch-attestation
>>
>> It seems to be a tool the maintainers can use for patch management. I
>> will have to play around with it and see if I can figure out why b4
>> doesn't like the patch series.
>>
>> Is this something that people have started using?
>
> I started to use it more recently. It makes it pretty easy to download a
> series and apply to a tree.
>
> For instance, take this entry: https://inbox.sourceware.org/gdb-patches/85a2f33d4ad12966dcb212e99e836175b69fddee.camel@linux.ibm.com/T/#t
>
> You could do this to fetch the patches:
>
>
> b4 am -M https://inbox.sourceware.org/gdb-patches/85a2f33d4ad12966dcb212e99e836175b69fddee.camel@linux.ibm.com/T/#t -o /tmp/
> Looking up https://inbox.sourceware.org/gdb-patches/85a2f33d4ad12966dcb212e99e836175b69fddee.camel@linux.ibm.com
> Grabbing thread from inbox.sourceware.org/gdb-patches/85a2f33d4ad12966dcb212e99e836175b69fddee.camel@linux.ibm.com/t.mbox.gz
> Analyzing 12 messages in the thread
> Checking attestation on all messages, may take a moment...
> ---
> ✓ [PATCH 1/3] Fix GDB reverse execution behavior
> + Tested-By: Luis Machado <luis.machado@arm.com> (✓ DKIM/armh.onmicrosoft.com)
> + Reviewed-By: Luis Machado <luis.machado@arm.com> (✓ DKIM/armh.onmicrosoft.com)
> ✓ [PATCH 2/3] Fix GDB reverse execution behavior
> + Tested-By: Luis Machado <luis.machado@arm.com> (✓ DKIM/armh.onmicrosoft.com)
> + Reviewed-By: Luis Machado <luis.machado@arm.com> (✓ DKIM/armh.onmicrosoft.com)
> ✓ [PATCH 3/3] Fix GDB reverse execution behavior
> + Tested-By: Luis Machado <luis.machado@arm.com> (✓ DKIM/armh.onmicrosoft.com)
> + Reviewed-By: Luis Machado <luis.machado@arm.com> (✓ DKIM/armh.onmicrosoft.com)
> ---
> ✓ Signed: DKIM/ibm.com (From: cel@linux.ibm.com)
> ---
> Total patches: 3
> ---
> NOTE: Some trailers were sent to the cover letter:
> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
> NOTE: Rerun with -t to apply them to all patches
> ---
> Cover: /tmp/20231122_cel_fix_gdb_reverse_execution_behavior.cover
> Link: https://lore.kernel.org/r/5483d77c72088a1e4d5dfed2eded2366643fc659.camel@linux.ibm.com
> Base: not specified
> git am /tmp/20231122_cel_fix_gdb_reverse_execution_behavior.maildir
>
> And then you can easily apply the series with the above git am command.

Let's wait until this Friday to see if there is any other feedback regarding this series.

Otherwise, LGTM.

Approved-By: Luis Machado <luis.machado@arm.com>