From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62099 invoked by alias); 6 Sep 2017 00:30:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62010 invoked by uid 89); 6 Sep 2017 00:30:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 00:29:58 +0000 Received: from [192.168.1.3] ([185.58.161.191]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MCPhl-1dgLfN31wf-009BnT; Wed, 06 Sep 2017 02:29:44 +0200 Subject: Re: [PATCH] Correct shell compatibility issue detected with pkgsrc. To: Joel Brobecker Cc: jhb@FreeBSD.org, gdb-patches@sourceware.org References: <20170905204239.17030-1-n54@gmx.com> <20170906001747.m3vs7rqzrvsrsss3@adacore.com> From: Kamil Rytarowski Message-ID: <071bf7b5-8661-6ac2-19fa-597af558c908@gmx.com> Date: Wed, 06 Sep 2017 00:30:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170906001747.m3vs7rqzrvsrsss3@adacore.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PJ8SGBKlledxSq8cC3MLWrnUXBroRJqB1" X-UI-Out-Filterresults: notjunk:1;V01:K0:VFjLbCBHO8I=:mwlZ4TTTbfR0+2cnw2QX5T yDbw0u5ZX0/Cibloz4+jR2j8pnCMo9K3mBImqMiSg257NWOjSmB44zTNZvgM7ZSvgKCMf/syi Rgxcz04+c3I40/wgKS9g/zo0JqlnxqyhjOmz6RBj49lP1iuCH2TthD4BA7uMwiX66UTKQjbZ+ gZ0wjfJZs0I1Cti7rY8iGp2PTqpMcc/aR1Mb8wlWnyV4ZfAcrtrTnb73WhTztnqIoVjfV/Ur+ XA1ij/Ovg9MySwTxfyEuhqmMsJenZ7KSEhsyswCjpaHbyE5mpLpNMe+HTk0fry+jfyOzcPSMd QcyImMY19u6WwDvFNnaYn3TH3yuBGW5nEdUTfPXw+moImtPTlt7kD+m6hSW+j4pYqncQ8Vzs8 S2IZIdpXY0hvkHzmIqhBa9c9s2HT2pb32Jx/bFQHAFMCE0HX/d7B/uZJqRSlUa9QEoE/GiFzQ pBQBy+vyBHWVuRUG0sTNclQoLsE4aiAxfwS45anhnpA5Mr2htXF6Xrd8ZlG0znbUt1KxXldPz v0oaoO/95+41oYFKp1yyfXBHUWe2eMW9vPQhN+YJ+YfjDLnOj+pJkdX2BEuabUGB1HflKw+c6 HMJX85Iro6lTvUdI0iYYGft5ymuXg6Atck8f9wwjUR0BZz87DsAREJzuPjHSqnAmSw2cEQSEe QZXXjGo9R6vAbFUITZvHiIcvEGgsmv9LNV3Ox0zhXVVroe0Ja7p5L8ho8VUxkbPWDxojL35Za kflWoIdKaFo+hb6ae4xu/WHIWEn2K9Q8o/tMuNbZWynWChjlMbzqd6FuE/CFatPj2ij+Q69iD 6IpZxOlH5zUoHM6CM+gf6rMila+Rg== X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00133.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PJ8SGBKlledxSq8cC3MLWrnUXBroRJqB1 Content-Type: multipart/mixed; boundary="Afmuaia1MpS5VV4SkWSLCLMNQoQv3OgX0"; protected-headers="v1" From: Kamil Rytarowski To: Joel Brobecker Cc: jhb@FreeBSD.org, gdb-patches@sourceware.org Message-ID: <071bf7b5-8661-6ac2-19fa-597af558c908@gmx.com> Subject: Re: [PATCH] Correct shell compatibility issue detected with pkgsrc. References: <20170905204239.17030-1-n54@gmx.com> <20170906001747.m3vs7rqzrvsrsss3@adacore.com> In-Reply-To: <20170906001747.m3vs7rqzrvsrsss3@adacore.com> --Afmuaia1MpS5VV4SkWSLCLMNQoQv3OgX0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1915 On 06.09.2017 02:17, Joel Brobecker wrote: >> String comparison of in a POSIX bourne shell must be done >> with '=3D', not '=3D=3D'. For example the NetBSD sh(1) does not >> support it. >> >> gdb/ChangeLog >> 2017-09-05 Kamil Rytarowski >> >> * config/djgpp/djconfig.sh: Correct shell portability issue >=20 > Indeed. Looks good, so go ahead and push to master. >=20 > I did notice you were missing a period at the end of the sentence > in the ChangeLog entry above, but it's in the diff. Can you fix it > before pushing? >=20 > Thanks! >=20 I've fixed it locally but I cannot push the patch myself. $ git push upstream master fatal: remote error: access denied or repository not exported: /git/binutils-gdb.git I have the papers done for GNU binutils, GDB and GCC. >> --- >> gdb/ChangeLog | 4 ++++ >> gdb/config/djgpp/djconfig.sh | 2 +- >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index 6d2eae58bc..a8e1837b6a 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,3 +1,7 @@ >> +2017-09-05 Kamil Rytarowski >> + >> + * config/djgpp/djconfig.sh: Correct shell portability issue. >> + >> 2017-09-05 Philippe Waroquiers >>=20=20 >> * objfiles.c (get_objfile_bfd_data): Remove useless obstack_init >> diff --git a/gdb/config/djgpp/djconfig.sh b/gdb/config/djgpp/djconfig.sh >> index 6c0d8698e8..dbaf8f5d76 100644 >> --- a/gdb/config/djgpp/djconfig.sh >> +++ b/gdb/config/djgpp/djconfig.sh >> @@ -92,7 +92,7 @@ TMPFILE=3D"${TMPDIR-.}/cfg.tmp" >>=20=20 >> # We need to skip the build directory if it is a subdirectory of $srcdi= r, >> # otherwise we will have an infinite recursion on our hands... >> -if test "`pwd`" =3D=3D "${srcdir}" ; then >> +if test "`pwd`" =3D "${srcdir}" ; then >> SKIPDIR=3D"" >> SKIPFILES=3D"" >> else >> --=20 >> 2.14.1 >=20 --Afmuaia1MpS5VV4SkWSLCLMNQoQv3OgX0-- --PJ8SGBKlledxSq8cC3MLWrnUXBroRJqB1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZr0IIAAoJEEuzCOmwLnZsLgYP/jOWSnCH6jUtoJwDNETI7sNQ W5+jjmyhcV0uKrZ3jAPYV8l8Aq3BzkwrCAhahSK+Urw7jK7bwBMHGGTCz2MzlAeo c6dFUueUXrPHYeNDU0OGpOvquSV+EYJUkqVIsqGitQ90YMtdCr/6DHEWfqhDeM5J s4JC0Lkn8nH0ixefw2mBDaT0WphWclO08dT4NTNniujsprlLRwq2QVnaQBvblWO+ iP/FPrjXhLUohEqSj040hf5svfLeF9fsfKlXDaXpScnNlfaUV0HbFAdQhEfHCEHv L2HlLFxRynvPHBT5hAW3qW9CZJ/IVOIK0r6Gxb6zgcf5afO2EBARcWCiiJsak2Pt OARc2pWhpwXwjPiqrtff1EiSPEh3SeZkX0y0RkdykJGOgk2IKLV1f2PYqatozIUH Lr4lm5bZ7/k+y/a2eztkOE6gx19dZrg0ljM9mkr6ZyjG4vrxfrR3kwV2VVlOaZPM 5Stqn+Exe0/Tr2VwhCR6EgWPFWgdzg8qINa06SdI7kQ9RmV8GYF3LvadIXrxROYF R4TDZKsRwHjWUy4RwM9ZUorXhROKN1C9o5Iu8YqAdOpoplBqsJzvFoQEzrOH/jqt am3lc/nPyRJNQG2y3ZB06dB0takEgq188Au5P+xV1qRZrknNUFDl9PT+m91hrF6M P5uTo+vcsyujHKMD0pKL =WbNT -----END PGP SIGNATURE----- --PJ8SGBKlledxSq8cC3MLWrnUXBroRJqB1--