From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24711 invoked by alias); 26 Jul 2019 15:40:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24703 invoked by uid 89); 26 Jul 2019 15:40:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*Ad:D*ca, H*r:10.0.0 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Jul 2019 15:40:39 +0000 Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CA7421E180; Fri, 26 Jul 2019 11:40:36 -0400 (EDT) Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function To: Christian Biesinger Cc: Christian Biesinger via gdb-patches , Eli Zaretskii References: <20190625220832.247935-1-cbiesinger@google.com> <20190722205121.89189-1-cbiesinger@google.com> <54adbe2b-3501-52ea-fdac-5a44f7869391@simark.ca> From: Simon Marchi Message-ID: <06c813cb-cd81-9766-b6c5-842f684e4293@simark.ca> Date: Fri, 26 Jul 2019 15:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00581.txt.bz2 On 2019-07-25 9:37 p.m., Christian Biesinger wrote: > I decided to follow your suggestion and add a lookup_static_symbol > function (to Objfile and gdb). I haven't had time to implement it yet > but hopefully I can do that in the next couple of days. Would you like > me to do Objfile.lookup_static_symbol as part of this patch or > together with gdb.lookup_static_symbol? I would say a separate patch for each would be good, if it doesn't incur more work. They can be in the same series though. Simon