From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id F18143885C3E for ; Thu, 19 Mar 2020 15:52:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F18143885C3E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584633153; bh=AYjSe/poAljYzonlIVU2wOdwWh39VkFvuO63Vxtyao0=; h=X-UI-Sender-Class:To:Cc:References:From:Subject:Date:In-Reply-To; b=X4iEnc58Te10vZE9Y/+Uu2X8ZnZlFQ/wNK1Wbq4lFQDW+fYP4byQl05UbKwJ/3VhY rDz5BIxsl5jMOyZZofdh6y+OtGFVKP7U3TnRbEoVPkXBvRtuomFJsgPtu0OIpzETTX tfKasxu5aQ1P01+RN1g0MPGkjWZWGkJPffl143uo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MrQIv-1jb6ow17yR-00oXSo; Thu, 19 Mar 2020 16:52:33 +0100 To: Simon Marchi , gdb-patches@sourceware.org Cc: tom@tromey.com References: <20200318231651.18045-1-n54@gmx.com> <20200319122844.24558-1-n54@gmx.com> <3bbb5348-a6bb-fac2-3ca1-2a3e8a1eb11e@simark.ca> <6e74c142-d3e7-6fd8-b765-594931be898b@simark.ca> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Subject: Re: [PATCH v4] Disable get_ptrace_pid for NetBSD Message-ID: <06b42cfb-3d53-cbfe-e7db-fafda1adaa47@gmx.com> Date: Thu, 19 Mar 2020 16:51:18 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <6e74c142-d3e7-6fd8-b765-594931be898b@simark.ca> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="du3ju5kVLj0EGcXkLZJGfHKtHhX5rBVjX" X-Provags-ID: V03:K1:MDcZBpstogUNKIJGpyiMWxXuR4JxEwi5tiruR1Fy5d1agjYPVsy 1G2akG4D00HUj0fFuePcqWmMa6Rl9DlcDthRAhCjnUiWIBM7aY6o2k+D6mPGKTPYjUUZfN4 rhqaCOb85QrKXBu8z/g6sJ/kc9nbTSzp53WSn3MY9267bugazFMg7YtSsWE/sNB5gfk/xGk 3x5pm4na3m5mj3loNBc5Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:dZHxJjU4Dfc=:bCFB7yrd+lGYgX2VqA8at3 urOrgvbr6/mTSCJkmm4QqWWzbguoytpLna5nXJTpsJoE++Ou5nsG81sG9zbLEc9EqQr9hPZR7 2yMUhkRNOfYEkrlNWPrFBBhr+3Ln6cr5CodDAXMQY5CLDz4SGLfeWVrsubFYWkA745QzDPmZP ztvxmy47xsnHMyXJ2N1PdZIEqNkmV0nFKt2jld4/6aRjVwo085mZ+ml6E3DR25G1QPiCirQPW 74vWasLSmpYT2l61wEx9e7mDjcbEip1F/W4VDSWNDS7+J491GzT3heRWuOMhvVwa4GyV/sSMd uuxY0839YF1STzuu8igJAkAlWkNwFaqy1d0ylxCR9/4BrJzxG5ZFEsVk4c9A/q1w3E4dnPtIf gpHQqd9T7OnBCJ6gGJQiwXN7MuA3ujdKHXBOnZcEF/0GHR4p/dBFaO4mZDWN1s5naAnE0z8cH JGdAgKHJlLl5uKICXCeoCAKz/Vb6yRwUY5eYc63/uiIxWBiocTIP3Xvbzab5Ul8t+rVZHmeoM OYSSCrfySNtREpfo8hzJ6yiqJ+PPzoS8E8Tji1VI9pRCHoaT4iAc1MDDNSULlRiXZtrASSpNC zHUZ9eQZl6lXU4dC3j5qpEU8s5unjwidvQka9W2B4yzkcP/LtCxJgMf6llFhT2y7JzwgWYviB wtg/PXq8Bh7AAEfdNUsJ2vYccN1uAjYuyS9nhD1CWiYGbnqhUaPdjI4IfTr575WzXYJEXyQNk ncqRZwHV72SAdoGn2FjFYYN9XObynMuPCBvLHoRhtJP9rCHHrSJ/jlOBw1oFUpOSeV/p+gGeT JDuioef9YU0xE69G8xFRxgx8HPZMWrCF7vepekjeetrX2IjsWzpKVCopFmsjLcoTO6xw5S3/z H57MZrKuwBB5oLP7ZI0aW37n0SmBDX7KMeOkFRpulavuzrtRV632Zd4WKy+BKrJ1CMCHXG9Jd Wmhzml0goXuNpw0LeukLa1M5D5rRLXkGFPYo0sTBkjVSYYC899sS3GCJwzjb5IGrjT91957cx 4HV2E+yuylk/VLHTEEmIwLboVgr0QYs56EYQ4Q7XEd3MlcYFp1B/tcY7RUob/9Lgea6UULeZV 4fSrfJfITlsQos0XE6zCzpCpvN1xzqhE+C8OTqrM9p2zKycqezpclhL2UgTAezSoPt576V190 TksY5pUk+/H75eiaZU3c2JSjo88jnJuIGKnvIc3YilV+pxkC6B8V6I4eQcl3mgnPjIkPA= X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2020 15:52:50 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --du3ju5kVLj0EGcXkLZJGfHKtHhX5rBVjX Content-Type: multipart/mixed; boundary="jDDQ0diU1gAo5CxwO8n8dPsAminJRx2Mx"; protected-headers="v1" From: Kamil Rytarowski To: Simon Marchi , gdb-patches@sourceware.org Cc: tom@tromey.com Message-ID: <06b42cfb-3d53-cbfe-e7db-fafda1adaa47@gmx.com> Subject: Re: [PATCH v4] Disable get_ptrace_pid for NetBSD References: <20200318231651.18045-1-n54@gmx.com> <20200319122844.24558-1-n54@gmx.com> <3bbb5348-a6bb-fac2-3ca1-2a3e8a1eb11e@simark.ca> <6e74c142-d3e7-6fd8-b765-594931be898b@simark.ca> In-Reply-To: <6e74c142-d3e7-6fd8-b765-594931be898b@simark.ca> --jDDQ0diU1gAo5CxwO8n8dPsAminJRx2Mx Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 19.03.2020 16:30, Simon Marchi wrote: > On 2020-03-19 8:55 a.m., Simon Marchi wrote: >> On 2020-03-19 8:28 a.m., Kamil Rytarowski wrote: >>> Unlike most other Operating Systems, NetBSD tracks both pid and lwp. >>> The process id on NetBSD is stored always in the pid field of ptid. >>> >>> gdb/ChangeLog: >>> >>> * inf-ptrace.h: Disable get_ptrace_pid on NetBSD. >>> * inf-ptrace.c: Likewise. >>> * (gdb_ptrace): Add. >>> * (inf_ptrace_target::resume): Update. >>> * (inf_ptrace_target::xfer_partial): Likewise. >>> * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'. >>> * (inf_ptrace_peek_poke): Update. >> >> Hmm, this breaks simple debugging on Linux: >> >> $ ./gdb --data-directory=3Ddata-directory a.out -ex start >> Reading symbols from a.out... >> Temporary breakpoint 1 at 0x4004da: file test.c, line 2. >> Starting program: /home/smarchi/build/binutils-gdb/gdb/a.out >> >> Program received signal SIGILL, Illegal instruction. >> 0x00007ffff7dda96d in dl_main (phdr=3D, phnum=3D, user_entry=3D, auxv=3D) at rtld.c= :1517 >> 1517 rtld.c: No such file or directory. >> >> >> I haven't figured out why by inspecting the code yet, I'll try to debu= g it later today. >> >> Simon >> >=20 > Ah, it's because ptrace returns long and not int on GNU/Linux. So when= we want to read > a 64-bits word from memory, it gets truncated. gdb_ptrace should retur= n PTRACE_TYPE_RET. >=20 > In fact, to be consistent, all these gdb_ptrace functions should be cha= nged to return > PTRACE_TYPE_RET (as a separate patch). >=20 Done in v5. I will follow up with other gdb_ptrace() instances next. > Simon >=20 --jDDQ0diU1gAo5CxwO8n8dPsAminJRx2Mx-- --du3ju5kVLj0EGcXkLZJGfHKtHhX5rBVjX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl5zlPYACgkQS7MI6bAu dmwOXw//Yrl8OYSeqUCBOKrplDMzoif7w1MsSb+0inxzl9EUS8fHkOkSFQXbqBeS dz+VjNJjsmvngWJ7SjhhxHVI/Me4bpdb+GMZZiKvA0RrnDedFnM7AeLhyBtf/STh ndbuRLFxPHHH+7E7LUA4eVqa9nTttBar6Kg9oQsTyzus9EgMT8WIQaFvOd7w/PnZ MiyCQF/J2rQBxKQkJRyoeSfvZJk6iADqtVIXCxZufanIwnKsFUQIirFypyf/cry9 PWiZjejakHBSfP/3J7712qXQe6vEPjTrxzaAVGFFNJ5G9e2XCqzUrKCD1H7PzM2l XhpPWj6u4PuOaMbz3vhAzeTl1lQXo3Qvz55qSgAQ/jPrWQraHMRuPyA9FAzWTll1 OAEmHIzZRSBTzeHvtJshrTCASXYfmZbWG3Ldybo1XHCb9hQGsqF1MgA1Z8boOxKM ZM93KvSo2iBNpRtBVqVuJLCQ0gS9h82qqbq6DYRNK3EoH0MQXRG6qdSUIwIbuEgv EWjmAItQeGpLalvC8yIKIgiIiBq+gjMLhdzNDfaCc75Fx7QJCR9X2zgTpzDN3+Jd JL3AwzSDfdeZGSWeO+SnfBQQnOURIgwTmRgKDgxOS4yX2tIOa4/8DgCmQ+3sgjew XVhWLpD4FGL3aYRkdOFP9IY4nIpj+qBzwBerEUAoePoURX5ENNI= =pjBX -----END PGP SIGNATURE----- --du3ju5kVLj0EGcXkLZJGfHKtHhX5rBVjX--