From: Alex Lindsay <alexlindsay239@gmail.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string)
Date: Wed, 09 Aug 2017 13:24:00 -0000 [thread overview]
Message-ID: <069c5b61-0a1f-7c2e-8f51-85cd031ea979@gmail.com> (raw)
In-Reply-To: <86k22dyno6.fsf@gmail.com>
Thanks Yao!
On 08/09/2017 06:40 AM, Yao Qi wrote:
> Alex Lindsay <alexlindsay239@gmail.com> writes:
>
>> Formerly, in cp_canonicalize_string in cp-support.c, the return value of
>> cp_comp_to_string was never freed, creating a sizable memory leak detectable
>> with valgrind. This patch fixes the leak. However, a longer term solution
>> would be to change the return type of cp_comp_to_string to
>> gdb::unique_xmalloc_ptr<char>.
> Hi Alex,
> Thanks a lot for the investigation and the patch. I revise it a little
> to use gdb::unique_xmalloc_ptr<char>, and fix another leak somewhere else.
> Patch below is pushed in.
>
prev parent reply other threads:[~2017-08-09 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 20:18 Alex Lindsay
2017-08-09 11:40 ` Yao Qi
2017-08-09 12:09 ` Pedro Alves
2017-08-09 12:31 ` Pedro Alves
2017-08-09 13:27 ` Pedro Alves
2017-08-09 13:41 ` Yao Qi
2017-08-09 14:10 ` Pedro Alves
2017-08-09 13:24 ` Alex Lindsay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069c5b61-0a1f-7c2e-8f51-85cd031ea979@gmail.com \
--to=alexlindsay239@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox