From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id X/zTBxXDBWByIgAAWB0awg (envelope-from ) for ; Mon, 18 Jan 2021 12:19:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 0EE621EF80; Mon, 18 Jan 2021 12:19:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 725D51E940 for ; Mon, 18 Jan 2021 12:19:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E1C21388E80D; Mon, 18 Jan 2021 17:19:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1C21388E80D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610990355; bh=SixQrgb0SBR3WPO95DRjBiGjj08mNKrOb3XgQ9fNqEk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=UmjauiJUmtwzmFHIKfQcEYiXaaoKNbxQNPb79rYIhUSwfwLrpJsoJKPR8I84/HssD BECky/pgApjWJ00EiJv1hp0ksx9tMez8uIjZhwETv6ntqq4siFRHBRxndr4KAUwop7 jQr5oqBbwnQGnVDRll2S4Y/IRUXn9XWFJtuoyFbE= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 17694384B822 for ; Mon, 18 Jan 2021 17:19:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 17694384B822 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10IHJ82R007147 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 18 Jan 2021 12:19:13 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10IHJ82R007147 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A9BBD1E940 for ; Mon, 18 Jan 2021 12:19:08 -0500 (EST) Subject: Re: [PATCH] sim: common: modernize gennltvals.sh To: gdb-patches@sourceware.org References: <20210117101044.32143-1-vapier@gentoo.org> Message-ID: <0674d2d0-2534-ac08-c83c-4330d090a1bc@polymtl.ca> Date: Mon, 18 Jan 2021 12:19:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 18 Jan 2021 17:19:08 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-18 12:13 p.m., Mike Frysinger wrote: > i had run shellcheck and the only warnings (about unquoted expansion) > i didn't think we worth fixing because of the limited scope of the > script. the variable in question isn't accepting user input, it's > operating on fixed inputs, and if we restrict ourselves to POSIX > shell (which i think we do), then our options are limited, and imo > the alternatives make it harder to read/understand. Even considering this, I think it's worth just quoting the variables and getting rid the warnings. It's trivial, and it would make any future (more important) warning more apparent. Anyway, it's just a suggestion, it's up to you :). Simon