From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72901 invoked by alias); 11 Oct 2017 13:36:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71584 invoked by uid 89); 11 Oct 2017 13:36:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:827 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Oct 2017 13:36:46 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v9BDaQam010371 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Oct 2017 09:36:34 -0400 Received: by simark.ca (Postfix, from userid 112) id CBDC81E541; Wed, 11 Oct 2017 09:36:26 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id D74251E517; Wed, 11 Oct 2017 09:36:25 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 11 Oct 2017 13:36:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Use std::vector for symtab_fns In-Reply-To: <3f6790bb-4a36-2439-dece-42fbaa25b55f@redhat.com> References: <1507665661-14742-1-git-send-email-simon.marchi@ericsson.com> <3f6790bb-4a36-2439-dece-42fbaa25b55f@redhat.com> Message-ID: <063e6faa390b1477d649167cecee2b97@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 11 Oct 2017 13:36:27 +0000 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00290.txt.bz2 On 2017-10-11 09:05, Pedro Alves wrote: > On 10/10/2017 09:01 PM, Simon Marchi wrote: >> Simple replacement of VEC with std::vector. >> >> gdb/ChangeLog: >> >> * symfile.c (registered_sym_fns): Make struct, not typedef. >> (DEF_VEC_O (registered_sym_fns)): Remove. >> (symtab_fns): Change type to std::vector. >> (add_symtab_fns): Adjust. >> (find_sym_fns): Adjust. > > > OK. > >> - for (i = 0; VEC_iterate (registered_sym_fns, symtab_fns, i, rsf); >> ++i) >> - if (our_flavour == rsf->sym_flavour) >> - return rsf->sym_fns; >> + for (registered_sym_fns &rsf : symtab_fns) > > Small nit: could this be a const ref? I think it's a good > rule to prefer const over non-const references if we can. Yes of course, that's an oversight on my part. Pushed with that fixed, thanks. Simon