From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KLUXBsm+bF9ZAgAAWB0awg (envelope-from ) for ; Thu, 24 Sep 2020 11:44:09 -0400 Received: by simark.ca (Postfix, from userid 112) id 16CB21EE05; Thu, 24 Sep 2020 11:44:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B9E5D1E8D0 for ; Thu, 24 Sep 2020 11:44:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71F09385781B; Thu, 24 Sep 2020 15:44:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71F09385781B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1600962248; bh=ouL/Dxsqg6yjZCZ0M7tKDLS4+IxICYvId1qgft2NNcY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Il+PKbBQHaLpY4Wh0M5ToNWoJiih5kzTxbSfUCk8TqUNianFUpOcAPXI+Ua9h7juN DMHV7S3CzIsNahEYCBFGp0Gc96JmSxWSqGsBKTAnCALZp10UUo6VJR350ge1AVVI1D 6yQPpRtFo/aiiZFVXhtq4ghIH3WaomzE2o+BFlgc= Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by sourceware.org (Postfix) with ESMTPS id BF8933857C52 for ; Thu, 24 Sep 2020 15:44:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF8933857C52 Received: by mail-qt1-x844.google.com with SMTP id d1so3312979qtr.6 for ; Thu, 24 Sep 2020 08:44:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ouL/Dxsqg6yjZCZ0M7tKDLS4+IxICYvId1qgft2NNcY=; b=IIH0KZOYUPzd+pvXn/DwlJKEfG7sQAQFa9otgEHgMwj+BAo0nFqDNleWpD+1+Skl5+ zYfi9evDMaG7e7O0dPDyoe8RPFt75fhS4HRbF+/89Iwy1UJLRz9uBeW7aDDTXKapX9U7 G8UwZAidiYH1mzfrmhgIz89oJ/c684+N2uVDObpmlOOKkfz+NP/NQ4/9CDjNQDNsqnhD dOEhfz1nyInLjdooByWcCzkB1ofIiGCAmoTqkJMiIuLjosNR4HE6D74P60uPJ/wzi2rs f4Re8fAbmQSB9L7hFwcZossPLTNDSekgnHiK6agKlljuJg1iqx7tG++/AjHYbJ0HMoVg ASYQ== X-Gm-Message-State: AOAM531DydRg34SUZA40PmpzqM1uGeO1n9umOVaCPJ8+RYEfCGXoCvYq tBZYfobT7qBUH//yaduz8AqzlZJ5CBmPMw== X-Google-Smtp-Source: ABdhPJyNBSRzE+X1pyoFDKKyNlgofHoHF3w2O9Clbg6MGswM+HxjNe+8KDYT7A0JaMFVnjTkvLPFMg== X-Received: by 2002:ac8:376d:: with SMTP id p42mr174690qtb.288.1600962246135; Thu, 24 Sep 2020 08:44:06 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:9bb9:918a:df76:92c7:9420? ([2804:7f0:8283:9bb9:918a:df76:92c7:9420]) by smtp.gmail.com with ESMTPSA id 18sm2327670qkd.120.2020.09.24.08.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2020 08:44:05 -0700 (PDT) Subject: Re: [PATCH] Don't drop static function bp locations w/o debug info To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20200612192108.11481-1-pedro@palves.net> <22959b69-54bd-012e-4026-feb4f02ac671@simark.ca> <5aea0e8a-2d19-3fa0-5281-86e41be4b8b9@palves.net> <1f254bd1-e75a-cdf3-e7c6-e89d51216635@linaro.org> <28a2dbf2-d9dc-0ffe-8b45-fa36a3522b25@linaro.org> <23b6b312-ddc8-cbc3-78b2-54cc099f9154@palves.net> Message-ID: <05e97151-b2bd-048b-36a8-085fd90d4358@linaro.org> Date: Thu, 24 Sep 2020 12:44:02 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <23b6b312-ddc8-cbc3-78b2-54cc099f9154@palves.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 9/24/20 12:35 PM, Pedro Alves wrote: > On 9/24/20 4:32 PM, Luis Machado wrote: >> On 9/24/20 12:16 PM, Pedro Alves wrote: >> >> It is the same case for AArch64. The reason for not skipping a prologue is because there doesn't seem to be one. The generated code for aarch64 is the following: >> >> (gdb) disass foo >>    0x00000000000008bc <+0>:     nop >>    0x00000000000008c0 <+4>:     ret >> End of assembler dump. >> >> I guess the assumptions of the test are valid for x86, but they're not valid for aarch64. >> > > OK. So the > > - "" > + "" > > fix should be all that's necessary. Do you want to give it a try? > Sure. I'll give that a try and will push.