From: Keith Seitz <keiths@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC PATCH] Introduce dwarf2_cu::get_builder
Date: Fri, 16 Nov 2018 14:39:00 -0000 [thread overview]
Message-ID: <05e40ce6-e168-186c-6d9a-b7aed1635287@redhat.com> (raw)
In-Reply-To: <077020e3a67e027bf358b899ba9ebdd4@polymtl.ca>
On 11/16/18 5:19 AM, Simon Marchi wrote:
> I noticed there were still some "naked" access to builder (places
> that don't use get_builder). fixup_go_packaging is one, for example.
> Is it expected or should they be converted too?>
I must have missed them in my initial pass. It is my intention to follow
Sergio's recommendation to make "builder" private.
Thank you for your comments.
Keith
next prev parent reply other threads:[~2018-11-16 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 18:57 Keith Seitz
2018-10-23 19:41 ` Sergio Durigan Junior
2018-11-06 21:34 ` Keith Seitz
2018-11-14 16:20 ` Keith Seitz
2018-11-16 13:19 ` Simon Marchi
2018-11-16 14:39 ` Keith Seitz [this message]
2018-11-30 20:30 ` Tom Tromey
2019-01-08 19:56 ` Keith Seitz
2019-01-16 16:38 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05e40ce6-e168-186c-6d9a-b7aed1635287@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox