From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by sourceware.org (Postfix) with ESMTPS id 129863858D38 for ; Wed, 12 Aug 2020 19:46:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 129863858D38 Received: by mail-qv1-xf44.google.com with SMTP id j10so1579342qvo.13 for ; Wed, 12 Aug 2020 12:46:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qmU1JUB8zlrmhe8U6SShYggf+P+QcYg8ewkRCt7xsEs=; b=GsoZwOsDYmPLn8U+6wmG15ex1rB08EsJuwd+P29tD3jaB30XQnnfip9mGpxl8Ic3Hm IE+0yQtUzBd0ANSnrA4a+zr8i9Tpx9vp1iKAKxU/fl/FX9vugVsrPOKHuq7p6ToKE6gZ NNH04G+BuClcO3kA+TjpGnrln5/Mn3RxUweU2Nxr3Zu+4igCbwn1mrpUzjRmNjXVlVgi 3JMnxabDXPCeF0urQAqnj/ssDMaQEf8hJJZDpCMBgr9GHndtATe3/X5ktoyK3Ymwzf3y 0Um7tb4evs/WLhgfaNTfDFk7gjFppOr08Awbm7lKy/Db1YNWvFYyW9b/+CGQYSR4tnYk qukQ== X-Gm-Message-State: AOAM533e1jBtspAwCJSTMCA0wt/OgRFcyHmEwPO94Xq3GjD0mY+LxNR3 2ycKpqXFmhLoDrUFKaTVLlo0+gNQAqo= X-Google-Smtp-Source: ABdhPJwM7J6/8w6UI1mLFPIY5KGGOM6mgEvbMKsOnqC53Qq/XAmdEY4ZcCzEbDAu6AABGeiu2n/c5g== X-Received: by 2002:a0c:ab16:: with SMTP id h22mr1275461qvb.72.1597261570431; Wed, 12 Aug 2020 12:46:10 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:9c50:2485:8bda:7d2b:129a? ([2804:7f0:8283:9c50:2485:8bda:7d2b:129a]) by smtp.gmail.com with ESMTPSA id t1sm3184233qkt.119.2020.08.12.12.46.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2020 12:46:09 -0700 (PDT) Subject: Re: [PATCH] Fix malloc allocation size sanity check To: Tom Tromey , Luis Machado via Gdb-patches References: <20200812191741.4220-1-luis.machado@linaro.org> <87pn7vhd9o.fsf@tromey.com> From: Luis Machado Message-ID: <05c71fb9-3e87-a964-ea63-85ca4ae30bf6@linaro.org> Date: Wed, 12 Aug 2020 16:46:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87pn7vhd9o.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2020 19:46:13 -0000 On 8/12/20 4:31 PM, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado via Gdb-patches writes: > > Luis> The following patch fixes this by making the length variable a size_t. > > main_type::length is a ULONGEST, so maybe that would be better? Yeah, I guess. I'll change it. I noticed xzalloc takes a size_t though.