From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id j+NjCTkMsmhUjQ8AWB0awg (envelope-from ) for ; Fri, 29 Aug 2025 16:23:21 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=ngvu51GL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 11C931E04C; Fri, 29 Aug 2025 16:23:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2361E1E023 for ; Fri, 29 Aug 2025 16:23:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A56493839E2F for ; Fri, 29 Aug 2025 20:23:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A56493839E2F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=ngvu51GL Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2072f.outbound.protection.outlook.com [IPv6:2a01:111:f403:241d::72f]) by sourceware.org (Postfix) with ESMTPS id 2CCD43839E26 for ; Fri, 29 Aug 2025 20:22:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CCD43839E26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2CCD43839E26 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:241d::72f ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1756498968; cv=pass; b=i3oJQRVXwJfrz73FYLKywHzxPGdCD493Es2EuR3uYBaFARPY3op7bibpbcy/rsDhLE7tdxTIGTYYyH20ZYa6B3UJEA7Il6CdtKMq0BwuWlaNX25sp2JPI2G09xDOArhFHRvHLdnHTQNPcCKM5cFy2u4/OLR1sl3OwM1lko5mVss= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1756498968; c=relaxed/simple; bh=xFN6qqbiHI4TzpPgKZajKhkbZ+l7n27vP3aRLrJsSBQ=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=sTjt+AwlIdmjSYXZLK0S1oueF82O7ufUq+jyFb2wYFDjx46KA1tg8k408i6IxMBvpxoHYZONpORNqBr+jfUBoTGuqIGnrF5Zyo4vD41pIMYQcEqrkCcT8eGA/7zWwWciVLFUhsrICjnmlZelw+4j0QbAjWqerrbRlrZOEAN53Q8= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CCD43839E26 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Yc4CKg7b75pWuhlUxAGkPbP2nxWSewdfxABiHgKExizLhZ3I0Gdxw6ipodYnxf6SK4MWYUDUTqCNlXT/OQlrW+sIyFEOK1pOSUhOJipKS+ygEoJOj0VSg9QoeN3nJQrIMglwRITNhis2hE1Tjont8faiJvmpdsPZumLfpeM4PlpTgFk8oz38nP6rSgjKXKN4p4VgH3hk/En3LhgHwHmw+I2/+hHfqgDUnFhO938aNG1DRnuqGe+pq8DEK7WAWC98dbecMR6HEQNjqM/r82e6SZEdHfwjoKG4UT9kvcpbldX9mctgMDCVZov7CdK5/q+qceipyxoOAPVv4785BQtvLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HmxUalItUxedOaEuDXreGw89bnxbHYvzSsxWVSjQq0g=; b=wRhZFOaH69heyeF6VLn19T51rd92iiSQ96D386f91Y4nIhPdIOUadCaxmh4VLEGhLCUuVRBGuJ1FRXejjG4E9iGT8hT0GuXUKANJaXOqAUoi7PVAlwxUGP6tFM4TGoOXsTv4xjSxmo07j6Q1aNRCh0G/WegWWzNIaU8mI9Wu9paQEniFK7nvv7VwxLWhpS4YVOsYyDXmNftO3xQWs091CAQrRw1m26KWMNxacMdY8rhrNbKyhlPCZ+sf2dbZ5XVwOcEMKuKkK6Uc48T8VMlnze6lQnjWDv0+28FQX/VGPxxw5bLalnalM4/mDH4f12+8TIRByICEmIeXWCPwqzAbPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HmxUalItUxedOaEuDXreGw89bnxbHYvzSsxWVSjQq0g=; b=ngvu51GL5g7gK3xSER+CnecoZSjfNfZqDVAmsE4gf3T/F8KPVUmoKLMjmuNk/0s6bKaD1d8BExa+MPcb4GZyvgavwJK3puzoH115SEPtQuakEZaYvIjCiW5x5vEgytzx/EF0u+Tar+rpEzydae507pb4oIVSaZNh3NKnB0QixsKs4wEzi4Wrs7fGLt4rtUcINCsRlaemQWM1zw9R9j9InScjy4MI0s7x+QSoSGsA0ZJZZRpnLag05Ib6f899sM8wN+giJL5YES1bGFljgiaP6cGf/hMGeOuxJdSD5rHanPqsozGA5MrxraYcO7ka0zqDsaXFR5n0Xn2FMx4JMiaeWg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT2PR01MB9746.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.21; Fri, 29 Aug 2025 20:22:43 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::1e89:d520:630a:7d86]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::1e89:d520:630a:7d86%2]) with mapi id 15.20.9073.021; Fri, 29 Aug 2025 20:22:43 +0000 Message-ID: <05b8aa57-598c-4ba2-95db-dada8b10894b@efficios.com> Date: Fri, 29 Aug 2025 16:22:42 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] gdb/objfiles: use filtered_iterator as objfile::section_iterator From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250828151100.84594-1-simon.marchi@efficios.com> <20250828151100.84594-3-simon.marchi@efficios.com> <871pouutve.fsf@tromey.com> <144605ab-8789-4eb9-9e6a-83b84b3dc2a0@efficios.com> Content-Language: en-US In-Reply-To: <144605ab-8789-4eb9-9e6a-83b84b3dc2a0@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0152.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:7e::11) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT2PR01MB9746:EE_ X-MS-Office365-Filtering-Correlation-Id: e39f4c7a-3075-4b5b-739e-08dde739cf10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z0ZweFZ5Z25TdCsxamhlU1dpa0hHLzU3S1l2ckJLaER4cW5CMGpzUk9SRThP?= =?utf-8?B?cGVUZXRXUUYzWVdSb05xaHBQVmxOQTcvc09MaTk0NGp0SkhCbUp6M1h2TEZE?= =?utf-8?B?VmRIT3NKNWJXSDdzSG10TjlrSGxRKys1eUE5N25lMzZxTFg2QWJ0R0dPN1Nu?= =?utf-8?B?Rlp1L0xvMVZPVVhnWWkzN3JEZnJwblBuaG8wMjJvazREbitwMGkremcwUXBJ?= =?utf-8?B?NjFoOVNKQmREUXhVay9vK0IrUytISmV0dlVDOTBsMEo5ZlVLQjkxdHF4bUFv?= =?utf-8?B?aDhqUHZaaTJrZXBtV1laTkdEalFiZFJLRGxlUjllWHFlRlZiNldGK0E2alJw?= =?utf-8?B?WEhKdENmczhpclBQZG1kYWxVL2w4dmpab3BRdlBSeFQxVFJPM1lpZ3JJQVBU?= =?utf-8?B?WmdpcTZhYWd3dHZSUFM0eXhpZHdVTlFCTWR5Q29wQjg1SUNndEdBL21CM0pL?= =?utf-8?B?aEh1NmFzb2tXcFdvZUhwbnVLd2Fkclp3WkkrRVdIMmMvTjdINE0rdUtsSk9V?= =?utf-8?B?cUp1dWwxVXVha2NLRHg1MVg3S0xCQmg1Vlh4NHJ1TnkxaWVQNzVLS1FwQlNm?= =?utf-8?B?OXVDUDlqcnEwM1F3QkVyWlQ5cnMvL3R6UFBpcGJPMml4RElSd3ZYRGQxOVdR?= =?utf-8?B?cHE3REpxckc2bC84aDRGZW4zRHBicWlJS3RCdkhqZG9aYXZYOE5PV2Y5LzdO?= =?utf-8?B?MWF2Q1NaL1BnTFFWdWJzSzAvSXREYVNreERmbE5zUlBLODFEdmhDZUR4Q3Fs?= =?utf-8?B?eGdoTlNRRlJCQ1lNcm5RUSt1cWtjbStLTGhnQzJENlhnRiswOHRwYUphNTh3?= =?utf-8?B?RUZUYlRsVENVbWpHVkVlWkluV0dTMDk0eUVhU05wYk9nVVRCMUt0bDE5c1Bv?= =?utf-8?B?aXJxU3IvaUY2enFReUxzMTJ4OUF0UGtWYVRLUXlZNlcyVGtDZjF5UFd6RkQv?= =?utf-8?B?Wld3cGIyVUdYZEF5OGxaSU10RDdKWGxoZ0lTMzVkT1o4MGFCaFFZN1Q5bmtq?= =?utf-8?B?SG5ybDZraVlZZFpjcFNLeWR1NmhNb1AyZ0hUcWx2dTFQUE1SbENHODRUSnFa?= =?utf-8?B?NGdQQnVpZDNMaUFDNzZmR0hJWVJIS1dVb1lBamUrcjc5eE13T2tpQ2J3WHVl?= =?utf-8?B?OThGdHgyZDNJc2VZanBPUndhcWc2cEtQQmJTZW1ZR1ltRUdzMHR1dGI1bDE4?= =?utf-8?B?ajZrSTJqb1poTkxaaDJHOHdma3pTOG54dVEvZ2NhN2RoRVF1b0dXdE9sUkxj?= =?utf-8?B?S09PZTN5M1FjRXlHcUk2SFFGUG5URVBtYzI0aVpQTUJWMDNSZ2QxV0o4NjRL?= =?utf-8?B?TVAxSHVwbUcxTTJDVGQxMVFpQmp2VC8zTjZFREY3ellhWGoybHY0KzZSblRD?= =?utf-8?B?WWlsNERpbWRuN1h5Wkd3c2pvSTU1NDJTVERWU29FNC9XQU9aclJqbzJiOW92?= =?utf-8?B?eUJxajNEZ3l6VjlmN0ZGTVRnWnRkZnNRamdIQkx3SGFLUk9oOHFxeG1XSzha?= =?utf-8?B?bkJlTU50RmRqRzIwZDVLVkE3Z1FTSUU3ZUlKVWUxZ0RVeFR5d29McmtwOHVl?= =?utf-8?B?eDlBQ09ldmN3ZjREUytHK2NaZWlQbkZ2L2lCbW9sN1l5YTVKKys2QjdYa1Vx?= =?utf-8?B?dWw1Q1ovMTdoVXdHdFNRUk0rNHN1RGtzUE0rUVUwNElCR0gySDRlZ0laMmV6?= =?utf-8?B?SHlMSW4xZ3BRYlpJS1BrMDYzVE5nbEtzM3llRjFhdXRpNHJYU1Z0YURVSE4x?= =?utf-8?B?aERybzd5ZVd4NlhzRk5lYjJmeGtSTU1RRXQ3dWRuTlhXWXRzTFRBQi9iZ1NJ?= =?utf-8?B?Z3NlbmhINGRKVzBoanBlNGtNTW1yL093dlZpUDc3UWZzZ081TXV5NCsxMHFU?= =?utf-8?B?MWxUR3FTTlZSbk5IVUxVU2pXZFlPT2RheCtqMFN5c01nV2c9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG5YbC9VOWMvaURtTS9mN1Z2WHl6RmJwM1gzR2drRTdXbS8yUjZXT2ZjSFRJ?= =?utf-8?B?YnY2Um5xZ3N0bER1QkszejRqcUxCdTN0UGFVN0cxays3aXpzSUdQVW1JQlV5?= =?utf-8?B?bTUwdEFpak9PRXZucmgvSm9zd0I5V1FHbnNjTjArelNpOVZqYnJscHU2VEt4?= =?utf-8?B?WmxFWmk5R2JtY3V1MnluQjlNM2dJUklyL1N5Ly93bWMzUlh5MkVGV1RLUDRO?= =?utf-8?B?UXhlR1NqMHZYdW5xbHBIMENZa280eHZSMFNIc0MzNmMxRnJNbFlGRWdOUCs4?= =?utf-8?B?ZzkzUWhzVGdtaWJvN3pJYy9ZY2ptbWZkQ2lpUFFRNTN3ZDZjTTRhU1NvNDVF?= =?utf-8?B?ZzNwMGlnQW9OeHZ5MENzV0lpb0xkaHFRUThLeXZTSThTaEErbmRUT3NhaS9q?= =?utf-8?B?SG1FeFJxQkN5RWI0b2FKdURqbmNycURpTGkwWkVJbEx1NGQ2MlJwVGVZQ216?= =?utf-8?B?THdrNFRMY0YwWkhWeXRrWjF2bjIzYUFKQWNqUFZtK2JnaTQzcDZKRFFWazd1?= =?utf-8?B?aDdQbmxJYXUwT24zeTVCSWpnS0F1NDc0cWZrOHhRSnBYNU5qelZXU0luMVNW?= =?utf-8?B?aUVVclg0dlpicmdUaTdnN2RMMjhsMkE4RkdJUk9EeXJ3QUlpdjcxMWxUUjBr?= =?utf-8?B?bHo4MGowVDVLOU1OMWRlZzhnVldlSzR2aXJUUEw0MVNDRDNSeno0NWtsSkRu?= =?utf-8?B?by93ZzY4a1k0NGM1REx6djJuU1B5M2VGeG84K3pSaXFtZGtVeThOZHdVRlkr?= =?utf-8?B?WThXY0N2ZGtZOGp2ZlNqMnpEYnNhaUJuc0NrV3YzK0hsSjFkOHc3UCtJRllR?= =?utf-8?B?LzI0Y09PUm9qZEE3eVJVcFM2bDdsVVc5cnBPQzZyWDVDS25DOHU2ZHFvcnNK?= =?utf-8?B?a1RrTWNoUUZVSDdZRU1NZWRwWk5iZ3RhajdPeHhhbWk1Q0dRaDVPMmtHc0RO?= =?utf-8?B?a1cyY0NaMENQV2YzTXpXVVNRei9MT2RJajdoSGN2b3RLcSt2K29uUUlZK2RV?= =?utf-8?B?cThqY2l0d3RrdWlnc3RlVFB3NWRtUGVjTFBzcG5BN2M0NUtnM1UyTmJMWHBZ?= =?utf-8?B?d09nK0Y5aWlER040Z055L25KVEt2NEVJRDFQdkt4TkhITWtRSjVIall5SlBu?= =?utf-8?B?UFNHQ1Y1WEJxZ3hVM0Z6UTV1QjJMbW5ienZwcEVhY2R1TXp6R2xzUDJpWStQ?= =?utf-8?B?K256a0d1VjYwS3B3bTJmM1dxejJDR3dXc1lFalcwSG80UHM4RTVkYzNsNHpv?= =?utf-8?B?bUVSaHBSWlNTTUZselpGazlaM1NTYUVFRmgrL1JqeFhJWG1USk0zWVY4Z2FU?= =?utf-8?B?QmFMK0ZOeTBpc2xVRXdoVkFiaHcxS2llWThOUUw0Tk1mY3FKNWx3Q05tbkZE?= =?utf-8?B?aU5wdVVmT25vSzhRSk5OemxTR0w1Z3NqY25yODM1R3pSRnl4a24rNXB3OEtp?= =?utf-8?B?UVZCQVBvUjVEOW81aHdUcTdOVms0cVQ4SzdmVjk1YjB1dVFWUmp3NHJVSUFl?= =?utf-8?B?elIva3JXZi9qTEtGSnB6SHhCVTJQczd4OEN6YlhCemY4eklFcmMyRkw5OGJX?= =?utf-8?B?WlNVWFBUTkZRVmpxeWU5UGFUNmE0MFcyaWFFU2VGcXJEOEQwV3BpMXBLQnVm?= =?utf-8?B?RDVrOEpZRHpYOHJyUHFRVWpBK1J4ejBxbHlDVHc3OWJnNmJkbS9yMDk5TG5D?= =?utf-8?B?TGtJUzlVRVoxMWwzb1dyeUROdWlEYjQ1OG0yNFgxck5LZWhrOXRwUVl3MGEy?= =?utf-8?B?R2xDRVY2OXNxNDZTOWF4YzJlUk16Q0pEbnU1WDJUTytlOHNtcGlqV3B3VTQ2?= =?utf-8?B?TmI1QVU5RHE1bEJkU05zcS94T2MvNSt4R3prMFNkVWJ1TzJDRkNhZ1hkSndF?= =?utf-8?B?TFArR2I5TzRuN0ZlOEN2S0hWdUIwUDhtTkh6d2FGc09menhZQ3JadFFFZllk?= =?utf-8?B?V3pKZkR2RDBDc0ZKVmZzUTVsaXBtWTJXWjNsQmF4andDMlNyVW1reDQ0dElU?= =?utf-8?B?ZnlKelN3dWJqUm82ZkU3aFYzNWhHbzFYdHRrb09nMVYwU3ArbVN0ZHlGMUFN?= =?utf-8?B?VHZ4Rjl1MkFKS3d1aGhwU3R6TnV2OTFrRGtXMFZhd1N6VXNvWUlMSjdDdGkz?= =?utf-8?Q?F1tFFrXHkNinZhQ95/s89b4QD?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: e39f4c7a-3075-4b5b-739e-08dde739cf10 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2025 20:22:43.2397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u5KtZTaOeqRS+BBeacB/4x8UPubFk8057v4tpAPxAlq0e/bEMpYRKkj0Z0qTo85DkXzr+20x+ZHXvfZe9CIOGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB9746 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-08-29 12:06, Simon Marchi wrote: >> Anyway if it didn't then that's just some pre-existing bug, probably not >> too important. > > I'll see if I can make it right, while at it, but otherwise I don't > think it's a big deal. Not that it's good, but it's not like we are > anywhere near to have const-correctness in GDB (yet). I tried to have: using section_iterator = filtered_iterator; using const_section_iterator = filtered_iterator; /* Return an iterable that yields the "non-null" sections of this objfile. That is, the sections for which obj_section::the_bfd_section is non-nullptr. */ iterator_range sections () { return (iterator_range (section_iterator (sections_start, sections_end), section_iterator (sections_end, sections_end))); } iterator_range sections () const { return (iterator_range (const_section_iterator (sections_start, sections_end), const_section_iterator (sections_end, sections_end))); } But it would require some changes that extend past the scope of this patch. Given that this patch doesn't make things worse than they already are, I'll push my original patch. Thanks, Simon