Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Andreas Schwab <schwab@linux-m68k.org>,
	Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/2] info breakpoints improvements
Date: Tue, 24 May 2022 15:17:24 +0100	[thread overview]
Message-ID: <05b3833a-9d87-53d2-e0a9-5b481e597929@palves.net> (raw)
In-Reply-To: <87sfozowak.fsf@igel.home>

On 2022-05-24 15:11, Andreas Schwab wrote:
> On Mai 24 2022, Eli Zaretskii via Gdb-patches wrote:
> 
>>> Date: Tue, 24 May 2022 14:50:01 +0100
>>> Cc: luis.machado@arm.com, gdb-patches@sourceware.org
>>> From: Pedro Alves <pedro@palves.net>
>>>
>>>>> A location only breaks if it is enabled, _and_ its parent is enabled, so never.
>>>>
>>>> That's what I thought.  But then why not "propagate" the "n" of the
>>>> disabled breakpoint to all of its locations?  
>>>
>>> Because then when you re-enable the parent breakpoint, you'd have lost the enabled/disabled
>>> state of the individual locations.
>>
>> I don't understand why would that be lost.  I'm not proposing to
>> actually disable each location, I propose to _display_ them as
>> disabled in that case.
> 
> I think it would be better in that case to omit the column or display it
> as "-", to indicate that it is ignored right now.
> 

Yes, we could print them differently, preserving the user-specified enable/disable
state.  We print them in uppercase N/Y when the location is disabled due to an invalid
condition already, for example.

  reply	other threads:[~2022-05-24 14:20 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 21:55 Pedro Alves
2022-05-19 21:55 ` [PATCH 1/2] Always show locations for breakpoints & show canonical location spec Pedro Alves
2022-05-20  6:45   ` Eli Zaretskii via Gdb-patches
2022-05-23 17:04     ` [PATCH v2 " Pedro Alves
2022-05-24 13:06       ` Eli Zaretskii via Gdb-patches
2022-05-25 19:32         ` Pedro Alves
2022-05-26 12:48           ` Eli Zaretskii via Gdb-patches
2022-05-26 14:04             ` Pedro Alves
2022-05-26 15:03               ` Eli Zaretskii via Gdb-patches
2022-05-26 15:10                 ` Pedro Alves
2022-05-26 15:33                   ` Eli Zaretskii via Gdb-patches
2022-05-26 19:29                 ` Pedro Alves
2022-05-26 19:55                   ` Eli Zaretskii via Gdb-patches
2022-05-26 20:40                     ` Pedro Alves
2023-04-10 15:07                   ` Andrew Burgess via Gdb-patches
2022-05-20  7:45   ` [PATCH " Metzger, Markus T via Gdb-patches
2022-05-23 17:05     ` Lancelot SIX via Gdb-patches
2022-05-19 21:55 ` [PATCH 2/2] Introduce "info breakpoints -hide-locations" Pedro Alves
2022-05-20  6:48   ` Eli Zaretskii via Gdb-patches
2022-05-20  5:57 ` [PATCH 0/2] info breakpoints improvements Eli Zaretskii via Gdb-patches
2022-05-23 17:06   ` Pedro Alves
2022-05-24 13:14     ` Eli Zaretskii via Gdb-patches
2022-05-24 13:45       ` Pedro Alves
2022-05-24  8:38 ` Luis Machado via Gdb-patches
2022-05-24 10:02   ` Pedro Alves
2022-05-24 13:20     ` Eli Zaretskii via Gdb-patches
2022-05-24 13:29       ` Pedro Alves
2022-05-24 13:43         ` Eli Zaretskii via Gdb-patches
2022-05-24 13:50           ` Pedro Alves
2022-05-24 14:03             ` Eli Zaretskii via Gdb-patches
2022-05-24 14:09               ` Pedro Alves
2022-05-24 14:25                 ` Eli Zaretskii via Gdb-patches
2022-05-24 14:33                   ` Pedro Alves
2022-05-24 14:11               ` Andreas Schwab
2022-05-24 14:17                 ` Pedro Alves [this message]
2022-05-24 19:49                   ` [PATCH] Show enabled locations with disabled breakpoint parent as "y-" (Re: [PATCH 0/2] info breakpoints improvements) Pedro Alves
2022-05-25 13:57                     ` Eli Zaretskii via Gdb-patches
2022-05-25 19:19                       ` Pedro Alves
2022-05-24 14:26                 ` [PATCH 0/2] info breakpoints improvements Eli Zaretskii via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b3833a-9d87-53d2-e0a9-5b481e597929@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox