Re: [PATCH] Add test for load command

Simon Marchi
2018-02-26T20:59:39Z

On 2018-02-26 14:15, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> [[Hi Tom,
> Simon> What do you think of adding this test to check this code
> path?]]
>
> Simon> There doesn't seem to by any test for the load command. I
> suggest to
> Simon> add this test, so that we can have a minimum of confidence we
> don't
> Simon> break it completely while refactoring the code that implements
> it.
>
> This seems like a good idea to me. I read the test and it seems
> reasonable.
>
> Thank you very much for doing this.
>
> Tom

Thanks. I did a buildbot run to make sure I did not break other tests
with the gdb.exp changes. It looked good so I pushed it. The new test
doesn't cover everything (e.g. writing to flash), but it's better than
nothing.

Simon