Re: [PATCH][gdb] Add register_test variant with std::function arg

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-09-13 11:40 a.m., Tom de Vries via Gdb-patches wrote:
> Hi,
> 
> Add register_test variant with std::function arg, such that we can do:
> ...
>   register_test (test_name, [=] () { SELF_CHECK (...); });
> ...
> 
> Any comments?
> 
> Thanks,
> - Tom
> 
> [gdb] Add register_test variant with std::function arg
> 
> ---
>  gdbsupport/selftest.cc | 25 +++++++++++++++++++++++++
>  gdbsupport/selftest.h  |  3 +++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/gdbsupport/selftest.cc b/gdbsupport/selftest.cc
> index d0511abe654..6d92844880f 100644
> --- a/gdbsupport/selftest.cc
> +++ b/gdbsupport/selftest.cc
> @@ -21,6 +21,7 @@
>  #include "common-debug.h"
>  #include "selftest.h"
>  #include <map>
> +#include <functional>
>  
>  namespace selftests
>  {
> @@ -57,6 +58,30 @@ register_test (const std::string &name, selftest *test)
>    tests[name] = std::unique_ptr<selftest> (test);
>  }
>  
> +struct lambda_selftest : public selftest
> +{
> +  lambda_selftest (std::function<void(void)> function_)
> +  {
> +    function  = function_;
> +  }
> +
> +  void operator() () const override
> +  {
> +    function ();
> +  }
> +
> +  std::function<void(void)> function;
> +};
> +
> +/* See selftest.h.  */
> +
> +void
> +register_test (const std::string &name,
> +	       std::function<void(void)> function)
> +{
> +  register_test (name, new lambda_selftest (function));
> +}
> +
>  /* See selftest.h.  */

I presume this is for your other patch ([RFC][gdb/testsuite] Register
test for each arch separately in register_test_foreach_arch).  Since
this is just for tests and we don't care about performance (at least, we
care more about simplicity), I think it would be fine to just make the
existing register_test take an std::function.

Simon