From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35920 invoked by alias); 13 Jan 2017 12:14:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35618 invoked by uid 89); 13 Jan 2017 12:14:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: einhorn.in-berlin.de Received: from einhorn.in-berlin.de (HELO einhorn.in-berlin.de) (192.109.42.8) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jan 2017 12:14:31 +0000 X-Envelope-From: doko@ubuntu.com Received: from [192.168.178.26] (ip5f5af7ce.dynamic.kabel-deutschland.de [95.90.247.206]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v0DCEK3L023553 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 13 Jan 2017 13:14:20 +0100 Subject: Re: [patch] update zlib to the 1.2.10 release. To: Jeff Law , GCC Patches References: <02ad1804-017b-3637-a532-aa6c7b8aa2a9@redhat.com> Cc: gdb-patches@sourceware.org, binutils From: Matthias Klose Message-ID: <0589dac6-ba69-17e3-ae7c-10b50738039e@ubuntu.com> Date: Fri, 13 Jan 2017 12:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00264.txt.bz2 On 12.01.2017 22:39, Jeff Law wrote: > On 01/12/2017 02:26 PM, Matthias Klose wrote: >> On 12.01.2017 22:17, Jeff Law wrote: >>> On 01/05/2017 07:45 AM, Matthias Klose wrote: >>>> These are the changes updating zlib from 1.2.8 to 1.2.10. It is only used when >>>> building without a system zlib. The new release includes fixes for security >>>> issues CVE-2016-9840, CVE-2016-9841, CVE-2016-9842, CVE-2016-9843. >>>> >>>> Checked with a build with disabled system-zlib. Ok for the trunk? >>> Were there any changes that we needed to carry forward or any changes you needed >>> to make to the upstream sources? >> >> I backed out the changes to the configure* and Makefile* changes (and only >> these), which are completely different to zlib upstream. There are no >> additions/deletions to zlib source files, so these build changes still work with >> the updated zlib. > One more note. I think that, in general, backing out local changes which don't > have a strong need to be carried forward is absolutely the right thing to do. > The less hacking we do on these libraries we pull from other sources, the > better, IMHO. agreed, except for the build system (and a locally fixed typo in zlib's ChangeLog), everything applied cleanly. Please import it into the binutils-gdb repository. Matthias