From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YgnRDOGmMmpY9QsAWB0awg (envelope-from ) for ; Wed, 17 Jun 2026 09:53:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=X1wgU8TY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 20EDD1E098; Wed, 17 Jun 2026 09:53:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E9D821E024 for ; Wed, 17 Jun 2026 09:53:35 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23B474BA23D3 for ; Wed, 17 Jun 2026 13:53:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23B474BA23D3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=X1wgU8TY Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012016.outbound.protection.outlook.com [52.101.43.16]) by sourceware.org (Postfix) with ESMTPS id D374A4BAD16D for ; Wed, 17 Jun 2026 13:52:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D374A4BAD16D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D374A4BAD16D Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.43.16 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1781704367; cv=pass; b=cDTViHKU0rQ6Lr3LxV8lG7RnZu1sMXJUGUf+ZjnGR9pee6kPejsgMBv9taXI8BopIwd18iYTYwNFUKwHT1TKmLiVgv4gXjd1q1AYUq3rY0RIfQlpkqZ4I1r9Iw6wgSPHcn5gj4BFhtvrHtD0OoeUtwP6C2DtQYiAeOavMcOhz6c= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1781704367; c=relaxed/simple; bh=9NOG8n+FX+I/Rx09b8uwLqTKOQFIbt5BVMV+XfnDJFQ=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=gg8BbvajalzanuRMjp3piATtLOBZHdMzuaZghfBZwKXM+WoqcePoWma1vf/QLoUvq8D0S+yIu7pGAkQ+PytcE5N9gPK1s7UWSNl5F2MFclrgWfydkqb4VC2nMhHHfjlyFHgHjBKiN6uEutia981d9WBCP2grMefPssJR6M7yHaM= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=X1wgU8TY DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D374A4BAD16D ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b8962byFFVbcG0D5qedqvFK1LaTFo7u1AkEWXR7fu063FMtxTUgelWuxsymBZWvXM0U5Tr9/mZAyFxvd5iBcsYw0T+yfSgE135xZun41MLPMsPOcNUpIoHSZbXNfLXoqNNGIDMMhlENCiFugRKzyDEyh3zoXtcsZQEBcqZIiSez4/YeffdseAb2leUSvino9Dwv2lqLd37WL3EPhLUVnvCsDwMe4tA6wz9Cxzue/l05qtzBPIw2CWIhRUDKsDo3iHyrfBRO1DRUuGqiH01znw0Ho0tNyPo+qU0XlRJtFZJdUHqo3kJjmdSRcGGO3NDmcTtTs9vySNHQlsLHZzl6HBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ci/xniTuehlzaNAiC1ZSP2aaUClf5R3K6cV0i/5lMZU=; b=Ry/ak0q+8pHVM54DOHwdU6sl8+/UD6kbQ+LFUF3xfOWiIUr4GtMGRqFBuL5wj/rIRGwNjFgEjMpmKRuM2DnpSp/GT4597qerfoT6i4XInfAe/M0G2WaKARNsUTPBzWDTULOjDVOlKuMRL9kxPu397B1r9G2NSL/BA7x5CXryNHqEQS6BbPnGFqth9e/W5LEZw+JtCA6IyzCcTmvVD17ai/YA6b/qy8/znzcv4sQByfgxSBunYfUwA4HJIjM1hGcAPxe9CNLvtnTF1QJ8vzjy1kX1kjzX0bQPIz/NF4dT8Cqp8tY3ctdaQ+LVYF11nCX2twn3dZrQnD+V6rbCueDBvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ci/xniTuehlzaNAiC1ZSP2aaUClf5R3K6cV0i/5lMZU=; b=X1wgU8TY01qZTUF4NEF4vh10P4MjVqLTx/mainqP30w0uufAnJUWvAG+SxzKPYvHq2nb2P2izcrC+T+T0ZX/IQMlfKtQeGKfrYRsCRfDIVCXgJeaI/UyNTHl06BSWflWGU0WRHM+0cCJWeF4GkDh/XsEEZxYfr8CET5z53I6dHU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from LV3PR12MB9095.namprd12.prod.outlook.com (2603:10b6:408:1a6::22) by DS5PPF5C5D42165.namprd12.prod.outlook.com (2603:10b6:f:fc00::64f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.11; Wed, 17 Jun 2026 13:52:42 +0000 Received: from LV3PR12MB9095.namprd12.prod.outlook.com ([fe80::b839:c282:4692:7305]) by LV3PR12MB9095.namprd12.prod.outlook.com ([fe80::b839:c282:4692:7305%4]) with mapi id 15.21.0139.009; Wed, 17 Jun 2026 13:52:42 +0000 Message-ID: <0570c772-9fc6-4fa6-9d48-20bf3d3f5fc7@amd.com> Date: Wed, 17 Jun 2026 14:52:31 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb: Remove redundant clear_proceed_status() call To: Claudiu Zissulescu , gdb-patches@sourceware.org Cc: pedro@palves.net, lancesix@amd.com References: <20260617124524.6160-1-claudiu.zissulescu-ianculescu@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20260617124524.6160-1-claudiu.zissulescu-ianculescu@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0340.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ea::19) To SA3PR12MB9091.namprd12.prod.outlook.com (2603:10b6:806:395::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR12MB9095:EE_|DS5PPF5C5D42165:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e79f405-c80b-4783-fea1-08decc77b34c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|18002099003|22082099003|5023799004|11063799006|6133799003|56012099006; X-Microsoft-Antispam-Message-Info: /xdtKG51KpENBB36fczDDUhYoyVbUCGUg5perGh148vrDwEipzzcvMFtEMo1ek5FswG+wd4WG4GRjMUeJRLQroQG2zWTwHbP8WZUipqGrPTLvbrDraPaO3FwQE0a/A1bnEdS37mdPo+C2lI4WBxClTxDPGrXO1benzNvc/urvDfTn7p2BYUXLm/GkQEnsC47LLIEq4gSI5cQ272JSsFaI34jRIfdjPuaU7Hps1XzzKMbITd16WJnHfOpfKneJN2Roz9S/4XIsYeAiuU2u0aNG7YLdtoTpc3PJ1I4Ql0sbUpbSzdUPghzdd2mpbSgeCi7hNtSx+hiA6M1Sv2Em0wLhW4DnkQ5axKClsqjgE4yW9Zt0LtiSt2yyZpO+LeFcFyXkpYvcMm3an0BukYbzLpDJlrB8ruRZj8LyOGxHtloCFC8QxBAHwbhwc9NSgiN1NtE/hsxVeTYzMqK3apNk2GA1vP88k7+aVkghUwQmFtgb4lyPemGs1BU2b7qbPbzbw+cUbSKoeCxoptZaPsRWlAzL4G/FC5HbOD41rqCzS2m8cmlos2NtI/zOYCszxawIv8s6H2/yLZ9aunfGgCfrOUCGmkPpAGw7Zvbz7F7MGO4h7Mc/cUbocXfvo4XvYpidSSslnnSnegjn+XlbETtqoI6Sc6JRz16BNKdwiTxXdif0sZCkM1zoKJIUvdeitfsguaD1vJgLxqMpngJvHOLhp8Sqw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV3PR12MB9095.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(18002099003)(22082099003)(5023799004)(11063799006)(6133799003)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0hiMnN2enRjSlZoNHRWSHFHb0VUaVFxQWZKckRxaXpLVjhkUFhqUFBiU20r?= =?utf-8?B?QjNrNjh1cmlWeUp1dWFkT3A0R0pmendFTWUxbjhiZVNQeGswMUJ0SDczSmVD?= =?utf-8?B?VVdGeW1SKzNCYVA0TFZaeXhqMUp4Q2JINzA3YVBTek1yaXlFT0ZISnovczVy?= =?utf-8?B?cjdvWE94VnRNTnZvczNCNk1oNUZEQko0WDNYUDBYWm1SYURHTnJQZmNKUzh6?= =?utf-8?B?SVhXdjloM0xPbnAwNWxZdGJhVkRpMjNjY09uSkpFblY2cjJZNGpJZWl5UnhV?= =?utf-8?B?RHBCbWRLcXd0SCt1ZWRjNUtwRDg4U216WFE4VWVGWlp4NExkRU45dDV5UGtI?= =?utf-8?B?QVV3R1YySUp5ckNtZ0dMblU4NE5kMDdzOGN5VktFKzN6UkZ2ZzRSY2s4blEz?= =?utf-8?B?OWNLSWE3ZHFON2ZDeGVDdnY0QkxOV0dFck1DRUUxZXdUUCs5YkN1bUNNcHZY?= =?utf-8?B?Z05LN0xDTUQyVitZRW9HRDd5RWNWaVhSZU85bzRDcHk4ZHl0cHQvNVpkMGFT?= =?utf-8?B?cDArSkJybm83ZWVQVHFTODU0SkJtM3FuZElzbzZsYXkvc1c1YWFNNjFGQmZS?= =?utf-8?B?SGRjMUpyUDlkeVpZcFNSL0JTS25UbndPV0hPN1JNUFQyVXpTQnFweDlZb0pR?= =?utf-8?B?cjEyQWY4MkhockpZYmVwanZHSUdMOWZxSEM3TDk3YjVlUVdOZ2Z4NmExTFNS?= =?utf-8?B?SFRyOWlGWkZyQ3Fsamt1UzJxZURvam5vT05iWS91R2FUeHh1Q09PMS9Jd0pJ?= =?utf-8?B?dGtKTlhJbjdvQVBZTllWSDlob09xa3BKanlRMVBacllDYUZZTXV3RDBYVzhV?= =?utf-8?B?eUl1T0hURkZOREpvaVptOUxSZXVDM00rRXpTMWp6SVpkZkY3dUIxTko4RXVi?= =?utf-8?B?Z1h6VWJBbmRBNVdoeGxpQWFQVlR4VzVaMWZwc1ZPaHM2NVpkZVZ5dnVSRXdF?= =?utf-8?B?UkVuS2JYWU1yZCtNRWNJcWs4QjFVMCtabHRCOEVQZUFRdHM1QnpycFpNb0hI?= =?utf-8?B?dTFJWHZpTTJVelpYQUptcHM2SWx5NjBNOGlPQURZWTNaeWpRYm0wbzRGZkxl?= =?utf-8?B?Yy9rNGJmL3RYWFBHYlRtcnNVbnoxRGxCWUVwZE8zVFVBaHBmRmhaSHBES0VS?= =?utf-8?B?UTBGaGplSnN2RGR6M1lPZ2wreE1NK3VGVk9OT0VSZXdHZ0lPSmQ2ZklkeFhn?= =?utf-8?B?R0tDb0U1em9KNnpjRklYbTRXYk5SSExUL3ZQcU56QU9KY205OVVsRkZMYWMz?= =?utf-8?B?WE5NMVcySkEvQlBPc3QwYTg1czdCUmxheVJrV2kxaWlJVzFDV1d0UWVhSEpq?= =?utf-8?B?RzhHT3FHTVhxZ1RFd2NncXlBZ21MTWx5d0NZRXN3SlNveUxkSVVRM0xaQW1R?= =?utf-8?B?eXVoejczNGl0R000MVo0azFtKzc0Vk9KMmFLd3pEamF5bk45enJmblJCdS9M?= =?utf-8?B?OGRoYW13dldwUmplbzhEYWFJVkFRSW5nQlBjM0grSnY4ZkR4SFhHRU1qblh1?= =?utf-8?B?VERpbVhnRGFyQzVZQU95SHZrWDAwdFJtUko3a2hLWUhSa1AyN3A0dHhPTnEz?= =?utf-8?B?cU1pK2NVT0Zjelg5NTRvZ0t3NE5zdms5V1JTeUtPNlB4N3dxWFZNMFRjUDND?= =?utf-8?B?QlBTQWFWdkZtYzhmZzVwWCtWL2NCZGpmQkI3dDFqUXFqa21ZbUpyUGw5YmYy?= =?utf-8?B?RmFKU2cwbEdyLzI5bjVKZE1EQ3NyWEY2Mlpia0FyZVdLYXVMMTd5aVk1TGNw?= =?utf-8?B?YWFIL2ZHL205MGR4NW9IQVVPbU1kREtja056dXU1OUE1dWxpeWNHdnE0a1c2?= =?utf-8?B?UFZJQlp0WXZITUZlMlVmdURiVGtmUGYvOGdwL3Y1cDV6WU80V01WVWhRREVw?= =?utf-8?B?eHhvMU1JUnBUd0tNQnVmQ3hvTmEwLzM3SER2SHBCYmRDckR3Rk9VZ1pYZGtE?= =?utf-8?B?OUJweWZKVDJhUWViTDlyaWxGa3B5bjBsL1AxSVh2dHd0RExFNy9Fa0NhMWgx?= =?utf-8?B?V1hXejRHL1RuR25lVlUzOTVUb0lnQnUzVGl6bHQydndBendmQ2VJS05PWUVn?= =?utf-8?B?SVlaMTY5RG1ncGJzMUh6dDZiY0JPY01mWm5JSGV0cXp1cTV6ZmIrUno5L3NJ?= =?utf-8?B?bXpJK2Q2alR0amRZTkJlbW9xKzF5WFNIL0FpMkNqbGVOQWQvZlFqcW9RWHlW?= =?utf-8?B?bG1BajVpMEpLcU9uRmZaREhYQU9DalpCd0lYVmdhaXdlbUF3eTAyOXhjVk5q?= =?utf-8?B?Y2E0NngwMnU5K1VSMkRtNEh1RWozMXgrNlQrY3VvMXhTS1NyN0FDSmFZVTlQ?= =?utf-8?Q?6zfkltuOLrRqaTHqKf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e79f405-c80b-4783-fea1-08decc77b34c X-MS-Exchange-CrossTenant-AuthSource: SA3PR12MB9091.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2026 13:52:42.7254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yUeIH6QZw7UWJIHUAOzLc+A7MgN+gC2p4fqGPY0Tx8x1rs3fvaocLO+YYaDI1nWJJ7Ju9hQoqAXJRoFN+LuN4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS5PPF5C5D42165 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Claudiu, On 17/06/2026 13:44, Claudiu Zissulescu wrote: > This patch fixes a Windows issue with "-target-attach ", where > "running" is emitted instead of "done". The "done" message should be > synchronous for "-target-attach", but "mi_proceeded" variable is > incorrectly set to "1" when clear_proceed_status(0, true) is > called. As a result, "mi_interp::on_about_to_proceed" sets mi_proceed > to 1, and later "mi_interp::on_resume" emits "running" instead of > "done". > > Remove redundant clear_proceed_status(0) call (the notify argument is > set to true by default). The init_wait_for_inferior(), which runs on > the very next line, already calls clear_proceed_status (0, false). A > new test is added too. > > What is new: > - Improved commit message > - Added a mi test for showing the issue in Windows hosts. > > > Signed-off-by: Claudiu Zissulescu > --- > gdb/testsuite/gdb.mi/mi-attach.c | 19 ++++++++++++++++++ > gdb/testsuite/gdb.mi/mi-attach.exp | 32 ++++++++++++++++++++++++++++++ > gdb/windows-nat.c | 1 - > 3 files changed, 51 insertions(+), 1 deletion(-) > create mode 100644 gdb/testsuite/gdb.mi/mi-attach.c > create mode 100644 gdb/testsuite/gdb.mi/mi-attach.exp > > diff --git a/gdb/testsuite/gdb.mi/mi-attach.c b/gdb/testsuite/gdb.mi/mi-attach.c > new file mode 100644 > index 00000000000..6fd195320a9 > --- /dev/null > +++ b/gdb/testsuite/gdb.mi/mi-attach.c It seems this file is missing the usual copyright header. Best, Lancelot. > @@ -0,0 +1,19 @@ > +#include > +#include > + > +#ifdef _WIN32 > +#include > +#else > +#include > +#endif > + > +int main (void) Code style: missing a line break before the function name: int main (void) Best, Lancelot. > +{ > + /* Sleep long enough (5 min) to be attached to. */ > +#ifdef _WIN32 > + Sleep (300000); > +#else > + sleep (300); > +#endif > + return 0; > +} > diff --git a/gdb/testsuite/gdb.mi/mi-attach.exp b/gdb/testsuite/gdb.mi/mi-attach.exp > new file mode 100644 > index 00000000000..d0bb7e778cb > --- /dev/null > +++ b/gdb/testsuite/gdb.mi/mi-attach.exp > @@ -0,0 +1,32 @@ > +# Copyright 2026 Free Software Foundation, Inc. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +load_lib mi-support.exp > +set MIFLAGS "-i=mi" > + > +require can_spawn_for_attach > + > +standard_testfile > + > +if {[build_executable "failed to prepare" $testfile $srcfile {debug}]} { > + return > +} > + > +set spawn_id [spawn_wait_for_attach $::binfile] > +set prog_pid [spawn_id_get_pid $spawn_id] > + > +mi_clean_restart > + > +mi_gdb_test "-target-attach $prog_pid" ".*\\^done.*" "attach \$PROG_PID" > diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c > index d9e924f16c6..f1660a02175 100644 > --- a/gdb/windows-nat.c > +++ b/gdb/windows-nat.c > @@ -1944,7 +1944,6 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching) > if (!inf->target_is_pushed (this)) > inf->push_target (this); > windows_clear_solib (); > - clear_proceed_status (0); > init_wait_for_inferior (); > > inferior_appeared (inf, pid);