From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49704 invoked by alias); 28 Apr 2017 15:08:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49643 invoked by uid 89); 28 Apr 2017 15:08:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f47.google.com Received: from mail-wm0-f47.google.com (HELO mail-wm0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 15:08:00 +0000 Received: by mail-wm0-f47.google.com with SMTP id u65so44834499wmu.1 for ; Fri, 28 Apr 2017 08:08:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cYsK1aoEE+SWZ9HAsx1Cgatlyne5NZyK3X2Mj25QanU=; b=b9CMQmMshh1aNVnn5DLibESeN5LGQH0D+HfSjIr+LI6i+WmmOSNFs5ml5H9SqHIxC/ XzERY9r5Qcm00+B6x6jMkjrE84WpVTMbdbo+823qduAfTi0ksHODbgOW9eJxInXSdwex SlHSSN7euxnzmg5spFbiYz4AwrZrHc15xj+hblASRGVZ0uEhuzsVwPFDifYpHw6fO2rY bv9+uh/P5Lymg5TANKH9KdLVTBVF9i5yvsotblnqmCkKO97vC8sWvEdmFAV+xB3i1LLr IYyDrZMyqX4gHmZX+BO2VpPNcK6E+5eSH+Dxy0VGSTd/RxaSBk9Tr6ICHoxO1A3fzLMp QLFw== X-Gm-Message-State: AN3rC/5OC+pbjFl5JH+uWwJVgYC7h+u3UAWuzo5Fl/uQ6otgEGNY28Ph RqGGdMx2s+Qmo56R X-Received: by 10.28.23.5 with SMTP id 5mr6336610wmx.125.1493392080201; Fri, 28 Apr 2017 08:08:00 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id j44sm1167879wre.67.2017.04.28.08.07.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 08:07:59 -0700 (PDT) Subject: Re: [RFA 08/10] Move some code later in backtrace_command_1 To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-9-tom@tromey.com> From: Phil Muldoon Message-ID: <055fa88c-fdc1-662b-2b48-af6a8d90aeac@redhat.com> Date: Fri, 28 Apr 2017 15:08:00 -0000 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-9-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00792.txt.bz2 On 25/04/17 20:41, Tom Tromey wrote: > PR backtrace/15584 notes that some code in backtrace_command_1 is not > useful when frame filters are in use. This patch moves this code into > the no-frame-filters "if". This also removes the unused local > "trailing_level", which I noticed while moving the code around. > > ChangeLog > 2017-04-25 Tom Tromey > > PR backtrace/15584: > * stack.c (backtrace_command_1): Move some code into no-filters > "if". Reads much better now, thanks. LGTM Cheers Phil