Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH] [gdb/testsuite] Fix target endianness detection on msys2-ucrt64
Date: Fri, 5 Sep 2025 11:12:03 -0400	[thread overview]
Message-ID: <0548d0b1-cb53-4719-9b8f-e32d0786cd76@simark.ca> (raw)
In-Reply-To: <20250905135241.17915-1-tdevries@suse.de>

On 9/5/25 9:52 AM, Tom de Vries wrote:
> On msys2-ucrt64, with test-case gdb.ada/big_packed_array.exp I run into:
> ...
> (gdb) file /home/vries/gdb/build/gdb/testsuite/temp/3162/target_endianness.x
> /home/vries/gdb/build/gdb/testsuite/temp/3162/target_endianness.x: No such file or directory.
> (gdb) ERROR: (target_endianness.x) No such file or directory
> ...
> 
> Fix this by using host_file_normalize in gdb_file_cmd.
> 
> Tested on msys2-ucrt64.
> ---
>  gdb/testsuite/lib/gdb.exp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 7a3ea8d9644..00a4c54e8a0 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -2611,6 +2611,7 @@ proc gdb_file_cmd { arg {kill_flag 1} } {
>  	}
>      }
>  
> +    set arg [host_file_normalize $arg]
>      send_gdb "file $arg\n"
>      set new_symbol_table 0
>      set basename [file tail $arg]
> 
> base-commit: aaad5a3254db53434eaf1cf70384e7ee0dfb886a
> -- 
> 2.51.0
> 

Seems fine.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon

      parent reply	other threads:[~2025-09-05 15:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 13:52 Tom de Vries
2025-09-05 15:10 ` Tom de Vries
2025-09-05 15:12 ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0548d0b1-cb53-4719-9b8f-e32d0786cd76@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox