From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111248 invoked by alias); 16 Jan 2020 04:23:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111230 invoked by uid 89); 16 Jan 2020 04:23:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2020 04:23:40 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 093A01E05A; Wed, 15 Jan 2020 23:23:39 -0500 (EST) Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level To: Pedro Alves , Tom Tromey , gdb-patches@sourceware.org References: <20200109005807.7314-1-tom@tromey.com> <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com> <437c1b86-0aa8-57b9-53e2-f21567e2bb14@redhat.com> <87c733a2-2b25-a954-88a1-9bfb1a7eca12@redhat.com> <4fed38dc-aaa7-b76b-880f-bab0b1b5add2@redhat.com> From: Simon Marchi Message-ID: <053b43db-381c-a72d-ea5d-9bcb74a8440c@simark.ca> Date: Thu, 16 Jan 2020 09:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <4fed38dc-aaa7-b76b-880f-bab0b1b5add2@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00444.txt.bz2 On 2020-01-15 4:35 p.m., Pedro Alves wrote: > Here's an improved version, which fixes gdbserver's standalone > build, simplifies gdbsupport's config.h (there's no need for > #ifdef GDBSERVER stuff since gdbserver doesn't use gdbsupport > as a library yet), and adds copyright/intro comments. I have to admit I'm a bit lost in the spaghetti of config.h inclusion. I don't understand, for example, why GDB needs to include gdbsupport's config. All the features that GDB needs are checked by its own configure script, aren't they? I noticed that build/gdb/config.h doesn't get automatically regenerated from src/gdb/config.in whenever the latter changes. It could use a Makefile rule that uses config.status to re-generate it, like there is for some other files. There's also the variable "generated_files" in the Makefile, should gdb-support.h be in there? > diff --git a/gdb/gdbserver/config.in b/gdb/gdbserver/config.in > index da8c313c360..9e661d8e13c 100644 > --- a/gdb/gdbserver/config.in > +++ b/gdb/gdbserver/config.in > @@ -1,496 +1,32 @@ > -/* config.in. Generated from configure.ac by autoheader. */ > +/* config.h for the remote server for GDB. > + Copyright (C) 2020 Free Software Foundation, Inc. > > -/* Define to one of `_getb67', `GETB67', `getb67' for Cray-2 and Cray-YMP > - systems. This function is required for `alloca.c' support on those systems. > - */ > -#undef CRAY_STACKSEG_END > + This file is part of GDB. > > -/* Define to 1 if std::thread works. */ > -#undef CXX_STD_THREAD > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > > -/* Define to 1 if using `alloca.c'. */ > -#undef C_ALLOCA > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > > -/* Define if self-testing features should be enabled */ > -#undef GDB_SELF_TEST > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > > -/* Define to 1 if you have `alloca', as a function or macro. */ > -#undef HAVE_ALLOCA > +/* This file is automatically generated from config.in. It exists so > + that "#include " in header files (including gnulib > + headers), includes this file, which then includes our real config.h > + (which is called gdb-config.h), along with gnulib's config.h. */ The gdb-config.h above should be gdbserver-config.h. Simon