From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17689 invoked by alias); 17 Oct 2019 02:21:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17648 invoked by uid 89); 17 Oct 2019 02:21:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2019 02:21:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571278866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uYnLkWQkgu78JEuKEXjy3wXmb000kEkHjlHWd/SWnmY=; b=JEZmzLE/RNYUFQigTDV7J26UomeozAR+eHN1VFrPtjF0l4vGUuxZzeWAn3rNnNNyuZ1CBO +6BGjO6ealA7/hx5mW0xQbQ/qnin6bKQ0BI0lp9cF0jdSPsKm286vGJpB1nc2fg0JIjFES 0p5eWlNVVF4vfbBJ095dblTFL705ujc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-250--m81JYzuNq6z0UrT2g6cVw-1; Wed, 16 Oct 2019 22:21:03 -0400 Received: by mail-wr1-f70.google.com with SMTP id w10so250487wrl.5 for ; Wed, 16 Oct 2019 19:21:03 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id r65sm726761wmr.9.2019.10.16.19.21.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 19:21:01 -0700 (PDT) Subject: Re: [PATCH 21/23] Add "info connections" command, "info inferiors" connection number/string To: Tom Tromey References: <20190906232807.6191-1-palves@redhat.com> <20190906232807.6191-22-palves@redhat.com> <87k1ah8bqr.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <053821eb-fbcb-bfa3-d604-b7e27c4dfe04@redhat.com> Date: Thu, 17 Oct 2019 02:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87k1ah8bqr.fsf@tromey.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-10/txt/msg00542.txt.bz2 On 9/9/19 9:18 PM, Tom Tromey wrote: >>>>>> "Pedro" =3D=3D Pedro Alves writes: >=20 > Pedro> This commit extends the CLI a bit for multi-target, in three ways. > Pedro> #1 - New "info connections" command. >=20 > This looks good to me. Just one question below. >=20 > FWIW I'm fine with the names you chose. >=20 > Pedro> + uiout->table_header (name_len + 1, ui_left, "name", "Name"); >=20 > Why the "+ 1" here? Without it, we get: (gdb) info connections=20 Num What Description=20=20=20=20=20=20=20 * 1 remote :9999 Remote serial target in gdb-specific protocol=20 Since the "name" column can include spaces in the middle of its string, it seemed to me that an extra space would make the separation more obvious.=20=20 With the extra space we get: (gdb) info connections=20 Num What Description=20=20=20=20=20=20=20 * 1 remote :9999 Remote serial target in gdb-specific protocol=20 We don't do that in "info threads", for example, so maybe that was misguided. WDYT? Keep the extra space or remove it? I'll add a comment if we keep it. Thanks, Pedro Alves