From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135488-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25452 invoked by alias); 30 Nov 2016 21:47:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 25434 invoked by uid 89); 30 Nov 2016 21:47:07 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:542
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 21:47:06 +0000
Received: by simark.ca (Postfix, from userid 33)	id A258B1E18F; Wed, 30 Nov 2016 16:47:04 -0500 (EST)
To: Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 21/22] Class-ify ui_out
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 30 Nov 2016 21:47:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
In-Reply-To: <f1a0fa51-0fbe-ec9f-e801-21eab202e4be@redhat.com>
References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124191825.26147-21-simon.marchi@ericsson.com> <f1a0fa51-0fbe-ec9f-e801-21eab202e4be@redhat.com>
Message-ID: <0534918562b519d02e113e5e2e3b8439@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.2
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg01028.txt.bz2

On 2016-11-30 07:46, Pedro Alves wrote:
> On 11/24/2016 07:18 PM, Simon Marchi wrote:
> 
>> -/* Create a ui_out object */
>> +class ui_out_level
>> +{
>> + public:
>> 
>> -extern ui_out *ui_out_new (ui_out_impl_base *impl, int flags = 0);
>> +  ui_out_level (ui_out_type type)
>> +  : m_field_count (0),
>> +    m_type (type)
>> +  {
>> +  }
>> +
>> +  ui_out_type
>> +  type (void) const
> 
> Just a reminder: "explicit" and "(void)" in multiple places.

Thanks, they are already fixed but it's good to double check.