From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3081 invoked by alias); 7 Jan 2019 16:14:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3067 invoked by uid 89); 7 Jan 2019 16:14:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*F:D*ac.uk, D*ac.uk, John X-HELO: plockton.cent.gla.ac.uk Received: from plockton.cent.gla.ac.uk (HELO plockton.cent.gla.ac.uk) (130.209.16.75) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Jan 2019 16:14:08 +0000 Received: from cas05.campus.gla.ac.uk ([130.209.14.38]) by plockton.cent.gla.ac.uk with esmtp (Exim 4.72) (envelope-from ) id 1ggXXS-0006kk-LU; Mon, 07 Jan 2019 16:14:06 +0000 Received: from cms13-02.campus.gla.ac.uk ([169.254.2.115]) by CAS05.campus.gla.ac.uk ([130.209.14.38]) with mapi id 14.03.0415.000; Mon, 7 Jan 2019 16:14:06 +0000 From: John Marshall To: "gdb-patches@sourceware.org" CC: Tom Tromey Subject: Re: [PATCH] Fix build failure with macOS bison Date: Mon, 07 Jan 2019 16:14:00 -0000 Message-ID: <051D67D6-A7D8-4A6F-A54E-501051C2D4BA@glasgow.ac.uk> References: <12BBB509-646E-4140-ACB8-856A453E5646@glasgow.ac.uk> In-Reply-To: <12BBB509-646E-4140-ACB8-856A453E5646@glasgow.ac.uk> Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-01/txt/msg00131.txt.bz2 On 7 Jan 2019, at 15:38, John Marshall wrot= e: > Tom Tromey wrote: >> Simon -- I can't readily try this patch on macOS right now, so I was >> hoping you could. >=20 > I have independently done the same bisection as in gdb/24060 (should have= looked at the list archives more carefully first!), and can confirm that t= his patch fixes c-exp.y. However the same problem occurs for f-exp.y (and p= erhaps others). Problem exists in c-exp.y, f-exp.y, and p-exp.y. The others have avoided th= is (probably mostly by luck) by naming their similar thing DOLLAR_VARIABLE = (d-exp.y and go-exp.y) or other similar names. John >From gdb-patches-return-153242-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jan 07 16:16:54 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 5517 invoked by alias); 7 Jan 2019 16:16:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 5508 invoked by uid 89); 7 Jan 2019 16:16:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1202, dear, officer, kindly X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Jan 2019 16:16:52 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x07GGjtu026647 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 7 Jan 2019 11:16:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 62CC91E7B9; Mon, 7 Jan 2019 11:16:45 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 9DC821E4A3; Mon, 7 Jan 2019 11:16:43 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 07 Jan 2019 16:16:00 -0000 From: Simon Marchi To: gdb-buildbot@sergiodj.net Cc: Nick Clifton , gdb-patches@sourceware.org Subject: Re: Oh dear. I regret to inform you that commit 053af8c9034f92d6e36a1180655ba22a65c56437 might be unfortunate In-Reply-To: <053af8c9034f92d6e36a1180655ba22a65c56437-master-breakage@gdb-build> References: <053af8c9034f92d6e36a1180655ba22a65c56437-master-breakage@gdb-build> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00132.txt.bz2 Content-length: 1110 On 2019-01-07 08:26, gdb-buildbot@sergiodj.net wrote: > My lords, ladies, gentlemen, members of the public. > > It is a matter of great regret and sadness to inform you that commit: > > Sync libiberty sources with master version in gcc repository. > Updated stabs demangling and cxxfilt tests to match. > 053af8c9034f92d6e36a1180655ba22a65c56437 > > might have made GDB unwell. Since I am just your Butler BuildBot, > I kindly ask that a human superior officer double-check this. > > Please note that if you are reading this message on gdb-patches, there > might > be other builders broken. > > You can find more details about the unfortunate breakage in the next > messages. > > Cheers, > > Your GDB BuildBot. Hi Nick, As you can see, GDB needs to be adjusted to stop using cplus_demangle_opname (it was expected [1]). It shouldn't be too difficult to do, but I would prefer not to rush it (take the time to test it, get it reviewed). Would you mind reverting this patch, just the time we adjust the GDB code? Thanks, Simon [1] https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01160.html