From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17559 invoked by alias); 10 Apr 2017 04:05:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9817 invoked by uid 89); 10 Apr 2017 04:02:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 04:02:05 +0000 Received: by simark.ca (Postfix, from userid 33) id 1E3F41E7F5; Mon, 10 Apr 2017 00:02:05 -0400 (EDT) To: Tom Tromey Subject: Re: [RFA 07/14] Fix up wchar_iterator comment X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Apr 2017 04:05:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20170408201208.2672-8-tom@tromey.com> References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-8-tom@tromey.com> Message-ID: <05064d2453aa53bca4b4f966a6ec95db@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00225.txt.bz2 On 2017-04-08 16:12, Tom Tromey wrote: > This fixes up a comment in charset.h that has been obsolete for a > while. I think this patch is obvious. > > 2017-04-07 Tom Tromey > > * charset.h (wchar_iterator): Fix comment. > --- > gdb/ChangeLog | 4 ++++ > gdb/charset.h | 6 +----- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 56b1a87..1cf860a 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,9 @@ > 2017-04-07 Tom Tromey > > + * charset.h (wchar_iterator): Fix comment. > + > +2017-04-07 Tom Tromey > + > * charset.c (iconv_wrapper): New class. > (cleanup_iconv): Remove. > (convert_between_encodings): Use it. > diff --git a/gdb/charset.h b/gdb/charset.h > index 9e8ca4a..0d00f56 100644 > --- a/gdb/charset.h > +++ b/gdb/charset.h > @@ -92,11 +92,7 @@ class wchar_iterator > the input buffer. BYTES is the number of bytes in the input > buffer. CHARSET is the name of the character set in which INPUT > is > encoded. WIDTH is the number of bytes in a base character of > - CHARSET. > - > - This function either returns a new character set iterator, or > calls > - error. The result can be freed using a cleanup; see > - make_cleanup_wchar_iterator. */ > + CHARSET. */ > wchar_iterator (const gdb_byte *input, size_t bytes, const char > *charset, > size_t width); Well, the part about calling error is still true (well, it's technically not calling error but perror_with_name). I think it's good to mention that the constructor can throw an exception. Simon