From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0D8wLuDL4mJpERwAWB0awg (envelope-from ) for ; Thu, 28 Jul 2022 13:48:16 -0400 Received: by simark.ca (Postfix, from userid 112) id BA1EC1E9ED; Thu, 28 Jul 2022 13:48:16 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=XTwlcvqS; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D0C81E87E for ; Thu, 28 Jul 2022 13:48:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1DE863858039 for ; Thu, 28 Jul 2022 17:48:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DE863858039 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659030496; bh=mXcXFoQSO4X6QSSoXpDuSgFyOVpim0demUuDLNeUVOI=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=XTwlcvqS78EnN9UDZ8JsUlvAWL2IvJGm4skWKMbheoyutEkW+whWSFc5i4PAtS0bQ gtnNbPEsDMWP7KCe7OBC8bobu5wpk4gL3xQp9b4+RiaOHLTTTm07vU5Nn3S9NNtcnl a9mXpHhThv+kj2Hy1XLUDzePTMjMvOEMtEDD+OmU= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 37A023856DF7 for ; Thu, 28 Jul 2022 17:47:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 37A023856DF7 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 26SHlo74014404 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Jul 2022 13:47:55 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 26SHlo74014404 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9D7691E87E; Thu, 28 Jul 2022 13:47:50 -0400 (EDT) Message-ID: <05032433-1cd6-e94a-0457-0fd46e4f7339@polymtl.ca> Date: Thu, 28 Jul 2022 13:47:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 6/7] gdb: remove code to prepend comp dir in buildsym_compunit::start_subfile Content-Language: fr To: Bruno Larsen , gdb-patches@sourceware.org References: <20220428033542.1636284-1-simon.marchi@polymtl.ca> <20220428033542.1636284-7-simon.marchi@polymtl.ca> <6e9157d0-4f5d-82e9-3588-9e5318e9cdb7@redhat.com> In-Reply-To: <6e9157d0-4f5d-82e9-3588-9e5318e9cdb7@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 28 Jul 2022 17:47:50 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Hello Simon, > > This change seems reasonable, and local testing found no regressions. > In fact, because this prepending code was not always applied, it > caused some problems when testing using clang, and removing it has > fixed failures in gdb.base/maint.exp and gdb.base/jit-elf.exp! Well, that's good news, glad to hear that! Simon