From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sd5JBBk762ltijgAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 05:42:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BVVppGXj; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BVVppGXj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0A84F1E0BA; Fri, 24 Apr 2026 05:42:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BE3641E067 for ; Fri, 24 Apr 2026 05:42:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5C6D84BB1C3A for ; Fri, 24 Apr 2026 09:42:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C6D84BB1C3A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BVVppGXj; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=BVVppGXj Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011037.outbound.protection.outlook.com [52.101.65.37]) by sourceware.org (Postfix) with ESMTPS id A055B4BABF1B for ; Fri, 24 Apr 2026 09:42:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A055B4BABF1B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A055B4BABF1B Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.65.37 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1777023740; cv=pass; b=Jz+2T4Q4rtj32tVOyF/hSU9/V72yEP+Gs1ZPygfV76Pms/uSPv59uT7/u4F2FNqlt7FE/s+lls5004y0b6QSaBjMv9bQDOyAiDnt4J9jQvLWZEdfMKZjzLYpdAuCWlPoN/UD4y1KOVqBbrs6P+uOWvGkelvgPXNjwafIoKiLexs= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1777023740; c=relaxed/simple; bh=L4b8kngL0LJwxbYgQZeaVoEr1P5y9vE4tZMSGkaINlY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=tzrCmsHPqhuGY7ZmOqY2wUFUlAUfrdyOhBI6ci8konGR90BbcZXwHSohaDsC5SvXQw2Hoia9vEeXuQ6c90raThPBwBu8hEmmjDq9AVgZCCjqhxPbRTQ7lstnF0jlmQ0uoXJLtRVA6+NpD3uiUfb9jzwPnAYvHd2QG9bk3bAqSsY= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A055B4BABF1B ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Iln2VWcmLE48TSCLpZwGj7nMiGsjSqSxED0Ww/nUMLYT0mHeCwtp5CfmbkxQNSjnITZq5TleisQ6oSssqGrOqlVkImJNhmnEqosG8ytevJusDVCln3MvTW8n4TTtFTbgIUnKfoMw/+9RCdpKKVEryGcWXleZ39d/qA+4noAEk+55z3ldguoQCI8c+u7yO4gvDC1rEZt76WKLMJ7WtfX/5HRAubTs47dzE+8ePcOE09VxU6OKBDg0Mt5wMUqZQ8I3oyv5gPTXb052LxzwMcEg1FxfmTEHap62REaEjHqCNLA8XR93U2e6TMPZGJdNrDVnNRk05WPOE8yLka0KZ8VopA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K9/gleVMk8HfxGy53u77G3wZ6xkiG6Xq9/eduMWbV8w=; b=SF/hQ/hkvmokBVGGld9D1ncA4ROngQhwB15cQBqZeTHPT2Si5NaOxtOaz0/IbjXvmpTXL3yojbPrKO7Ljc4W/+FHXIiOz6qLsPtS84Uh1fOmf9eEfiJsAfCrBjfxBLTUJepT8zJVzLwrfd80TckdoLykNxDIReDBtJ3Caz3Jk5NPTbWge2T3fWd+sF1UcXq45Z1Yvxkk8uiDxG5XouIGVtFtMX/SQEL3aRK3ES9Drl0p7tuwxpV300ymPijc598WvRT25K6P4iKiVmjIWw/0gainsWK4v2nZqDfNsKzZpuYx2W3z5lCejiiE9x/F/zrOq/vq5djALuk5/f+dVn1sYQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=tromey.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9/gleVMk8HfxGy53u77G3wZ6xkiG6Xq9/eduMWbV8w=; b=BVVppGXjMZPngjWL38sj36wo9RTBtbSIpuX8vCqvxXU2AS0flZW1zKBxazEtmcoPPO/Mw/YELYE1ceJaDZH5yaYcu/UEOEY5sSnjMG4mz56roAEifZZAUXofRu+2T/imzUzXO2y7sMI966CYhHNeObgfo4JZbkp33CRSyP62BAc= Received: from AS8P189CA0033.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::16) by GV1PR08MB10572.eurprd08.prod.outlook.com (2603:10a6:150:169::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.21; Fri, 24 Apr 2026 09:42:14 +0000 Received: from AM4PEPF00027A63.eurprd04.prod.outlook.com (2603:10a6:20b:458:cafe::3b) by AS8P189CA0033.outlook.office365.com (2603:10a6:20b:458::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.22 via Frontend Transport; Fri, 24 Apr 2026 09:42:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM4PEPF00027A63.mail.protection.outlook.com (10.167.16.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Fri, 24 Apr 2026 09:42:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rKjKzBknAo8KD9NZJMEn7VQABDAoitEGAzZpMMFplIdFExXY8HGR4U4aYknDLovdy2PVtUeSN5hJ7t6GPOHpJZAQhlbX7DS7a2qIxXwayqc+EWpBHpFuDgHoWScnLi9f4yG1HAJOs9bxWVChlm8lUmp8tGKfBVJt1tPoqqVcXqBn43bG0KAswPGDk24SKmYeYm1oh8dWMlIWF21tdKEcT9d3XYroMuR3+g5ErhmkXplRi5V+AwVYCj4X9ISto0tsyhGsQauvTfcTIJc2Gd7SS/d3vbTioO7ouq357rShIESb9W7H9HdEM0abX8Zg5N/Bfbk9QOp7D3bwrJbpiqtXPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K9/gleVMk8HfxGy53u77G3wZ6xkiG6Xq9/eduMWbV8w=; b=a1fT0OgSQTcscbomse/AIZuAA3kU9lNA0R3HOmsRsmz6Cl7Zl9v5syKeST+NtP4zgO3M6p6kr02HJQzJ9goiONQbCkrQwKOOA3ejuep5zObchRjPxYdhPSmQtBMNlRYVq3smb7dRn4+vLb0EqhFXcneWNrbNuyKkmwyH6jHNBDsKUa3GNjDaMoQyHSPyoF8Os6pEMl/tHfSr33479mtk3X3NwIh7xrTDgUC+vTNpA6Ej8hdv5d9TzhByUPwl6Zv9rKa7wzmQ+oDV3sJEwdZbujZy5PBlqK0L9QW9nMTqIyYVJtH4cu8/WW2hgG9WYQUh+XIQ+SdNGJ+mjW1EWVZuQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9/gleVMk8HfxGy53u77G3wZ6xkiG6Xq9/eduMWbV8w=; b=BVVppGXjMZPngjWL38sj36wo9RTBtbSIpuX8vCqvxXU2AS0flZW1zKBxazEtmcoPPO/Mw/YELYE1ceJaDZH5yaYcu/UEOEY5sSnjMG4mz56roAEifZZAUXofRu+2T/imzUzXO2y7sMI966CYhHNeObgfo4JZbkp33CRSyP62BAc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) by GV1PR08MB8330.eurprd08.prod.outlook.com (2603:10a6:150:85::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Fri, 24 Apr 2026 09:41:07 +0000 Received: from DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968]) by DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968%2]) with mapi id 15.20.9846.021; Fri, 24 Apr 2026 09:41:07 +0000 Message-ID: <04df72d5-14aa-40f4-ac17-79df1b1e8421@arm.com> Date: Fri, 24 Apr 2026 10:41:06 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] gdb/python: migrate Python initialization to use the new config API (PEP 741) To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260409105155.1416274-1-matthieu.longo@arm.com> <20260409105155.1416274-4-matthieu.longo@arm.com> <87v7dpshv2.fsf@tromey.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <87v7dpshv2.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PA7P264CA0155.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:36c::9) To DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB8663:EE_|GV1PR08MB8330:EE_|AM4PEPF00027A63:EE_|GV1PR08MB10572:EE_ X-MS-Office365-Filtering-Correlation-Id: 47d2bf26-c738-49cd-79fa-08dea1e5c3ad x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|366016|376014|1800799024|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info-Original: qEm+ef4DYqFSotCxWvH+mdQjeIF0lTJRR/TPkmAo8Fdkj36n24gwu9gvMw9WorgNQFTHN/Ks7lAdhOzxHns15pSQFSG/ZQQK8VN7rG6zVBvx+CKfpS0LwleRfjd9syhKAucrZcRrHwDdS3zy6SCDzxgnXRBGVnMFqnfX79caUClUVoK9VGy73Q06uCvM741ljxptKcY8WNazJv9QQOsKGCOYYiJcpbHu0ftIeY4jaxm4QYdkPXlG3w7wpLK/DffmiLBgXq3VaGbOai2ha7BLACxBdAfuv3/5yZe6ijT0iVoYaXmio01bsAAlXcfQG/ORt37Fcn4tqjT4819ItH6vnI3+Slfef/C60/r7LFC+3JKBBXcDcWnRllLEpoa1MDR1ji68dbi33OhrvffRe9kTbUOOzr9irc+VK3BW3nuQgq2SJ7tQ++8xd47WUCnApFZLNreL68FJqcXjsaJ4Co+nDqGsnb2WPwcR5JG8uBfWk7OTL3P3Y5lj9msgllrGUSuLFbqgiHALMTPv4RckYLadvuckfjF/s/edAeRp92u6hIQaFKUoMgvaGHtGtnwQZ/Ktw6P5+3/fv7STE17T4+bOf/vshvvrNYKejk3zvYylFM0pbBrUATYGHu37c++Eh5Bt1Oaz0U+reEfLgVNPIC87EY754rNUv/DrOvFWrFD88aSZKCmeB+sY3s6/s3d1BE+sqoo3y+jnX4TaOWQ9ZMiNdanRJFQILmoVPPy+ZEeTr40= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8663.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(56012099003)(18002099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: EIN7g5AcPesPJMFI7s4hRxyzj7i0BkbTjJciQB+qPNtOoBvAksNbrOt7E9I0Rv72mvpmsLFeeyA4//aVjv7L0aB6C6oaHHp1OqVRNq15qCi9dhjfhJt+oyKMDTcKoh8z8ogsfp1xwg9VC0YtlZ3GYG4z4u5XsqfNKLJUJzrqzCfpueX+dCv+akqQMdJb6xy2OvjYQKD7oGLc8aDBXxz7f5iKDxIFmQIjjNfMknDsUnSZ0Y/wqgaGgnDLwiBXcnJb4sKFIFIsP+DVoBMww2wk4dGrSYKLCzjiZFTj7yYH/jcJZnNKjIjluTBgjT7mn9HSjHIEiX6B0Ld7OJ+DrL+6lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8330 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A63.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ca50bb0c-10c3-49e7-694e-08dea1e59c11 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700016|1800799024|82310400026|14060799003|35042699022|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: t9pg1VX/+EplQhavj2muxRpu7PZqBvxgroHqGNRoYjEu1TBqzZctRMmNeeyTSIivXlR9ikxWt6SHZC4OyjuYd4OaGTFkHokJu/k27SAiFNwazxqksVIHASj9pbpco+fflJFzVfDi8fip8odgx1nQ0QQKP5Oo8McB4bDFmL1GaQytGmxcK/wJvJpJhTnjscYBbP71vX9GS1gcZA0tjhmmUJcaxz5blzAeAziu7f5H1uf74syIKHPDhUtnj93UfwUcJlRXjXzgjwewJnrGJDIQRp1cAn2AoujPSxVmJaQfmHWmeniSFTcKuOI5gRUc0r34ihdb6F+lHY4p89obPnmBaUx5EHdI9pQPv+Pq8VKnrEvbiroHjajr8tFsnyh27il1JFKvMXAWMr5gA33GDksMy7iS7jpKgasSMmZrKBUS/JV01Z9TjXBGdHUSs371ITNQvBA/ip/DWoWf6jxW64wOhJ9VpzleGhtq12E0tKy2ZybZeGDnQKk47ZAdyz9erOijJERD1d4q9pzSMFlvpNjrnRQQNuLoeko1SdxdNEQe0PaP6wfWJp6ivHF0jdTjK5KW3ggjBBSdGHezKB5K/XDWUEz+wZnuz9J4/hqhLtEyZehVt88Mvo0t/QEi6OutiyAUdw3aMgwaPYdfM5U3G6m2acWARWK2yu0AAGIVxtWbpT+sfHCoJ4sPrqIStyXK3VTF2ndTAVC5lDgnc4/lWn1Dspmpt2FOiq+DnaYnHgJ0rBRvjgZ1+lpDK8GUa5IYRhUq2P5J1G8+OUthMn65XqUmzbSaVWelIS3dPvA7BFXqhS0= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(14060799003)(35042699022)(18002099003)(56012099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: j3084cX0DD+hbPQ7ZFeOSI8ownJLK5R8mXWKjfR5X2jv8k56xoeijnhZUa/JVho9vioZv07jKV6gsw4a0hDk0kAHfHlL6v5TR+40lIsSOkNW7jZpGTzH03UFg3AXsUdazt6SfgYhpjs1pccKeUcJg74XDn6rfHO44Af0c+A2mx+KTUgi97S18HZxjoYGhyv6J6TPcZQ1gHMRe3zIfoC8vy7lljSE9RHSSjuegbMcrUU1f9IhCu+el0OB3VH5RQxEJi96ob7fZ1+p53B957OTSbo9WUy25HltJS+TmmVxveBkRniQHbHBWamL13EBh7S/9Vz4hsPwbEkl51JKTjdUWcJw+T8vduVzOc+Gq9Oe0Ds1SnjKNNwTT0iTT49+nzi+BAZh4qaVj9B+8KBOYTQBtSm5VVUcit3bjOrSQ+ZlIoHgEM/JdRoyuTk2WF8YVGdC X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2026 09:42:13.5337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 47d2bf26-c738-49cd-79fa-08dea1e5c3ad X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A63.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10572 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 17/04/2026 16:53, Tom Tromey wrote: >>>>>> "Matthieu" == Matthieu Longo writes: > > Matthieu> + PyInitConfig *m_config; > Matthieu> + bool m_err; > Matthieu> + bool m_py_initialized; > > These last two can just say '= false' > Fixed. > Matthieu> +}; > Matthieu> + > Matthieu> +gdb_PyInitializer::gdb_PyInitializer () > Matthieu> + : m_config (PyInitConfig_Create ()), > Matthieu> + m_err (false), > Matthieu> + m_py_initialized (false) > > ... then they don't have to be initialized here. > > Matthieu> +{ > Matthieu> + if (m_config == nullptr) > Matthieu> + { > Matthieu> + throw_error (GENERIC_ERROR, > Matthieu> + _("Python initialization failed: memory allocation failed")); > > No need for the braces. Also this can just be error (...), throw_error > is normally only for special things. > How is it supposed to work with error() ? error() calls exit(EXIT_FAILURE). It seems to me that throw_error is needed here, otherwise the code in ... > Matthieu> + const char *err_msg; > Matthieu> + if (PyInitConfig_GetError (m_config, &err_msg) == 1) > Matthieu> + throw_error (GENERIC_ERROR, > Matthieu> + _("Python initialization failed: %s"), > Matthieu> + err_msg); > Matthieu> + > Matthieu> + int exit_code; > Matthieu> + gdb_assert (PyInitConfig_GetExitCode (m_config, &exit_code) != 0); > > Can't combine a side effect with an assert here. > Fixed. > Matthieu> + throw_error (GENERIC_ERROR, > Matthieu> + _("Python initialization failed with exit status: %d"), > Matthieu> + exit_code); > > Also same here about error; and does this code need to clear the Python > error or anything like that? > In my understanding, the error should not be cleared. The doc (https://docs.python.org/3/c-api/init_config.html#c.PyInitConfig_GetError) says: The error message remains valid until another PyInitConfig function is called with config. The caller doesn’t have to free the error message. > Matthieu> + catch (const gdb_exception_error &exc) > Matthieu> + { > Matthieu> + gdb_printf ("%s\n", exc.what ()); > > Use exception_print instead, probably with gdb_stderr. > ... here is irrelevant. Am I misunderstanding something ? > thanks, > Tom Matthieu