Re: [RFA 19/22] Convert tid_range_parser to class

Trevor Saunders
2016-10-05T02:16:20Z

On Wed, Oct 05, 2016 at 12:09:13AM +0100, Pedro Alves wrote:
> On 10/04/2016 08:24 PM, Pedro Alves wrote:
>
> > Anyway, I have to disappear now. Will continue later.
>
> Here's what I ended up with, after reading your version
> in more detail. That brought in the "deleted" copy constructor/assignment
> operators [1], and "const" in several methods, which I then propagated
> to number_or_range_parser too.
>
> WDYT?
>
> [1] - I'm pondering making those use =delete if compiling with
> a C++ compiler, behind some
>
> #define DISABLE_COPY_AND_ASSIGN(TYPE) ...
>
> macro.
>
> Or, maybe add a gdb::noncopyable class that non-copyable
> classes inherit from privately, just like boost:noncopyable.
> Anyone got experience on the latter, and whether that turns
> out to be a bad idea?

when Mozilla supported compilers without = delete there was a MOZ_DELETE
macro that was defined to "= delete" when available, but I've never delt
with the latter style.

Trev