Re: [RFA 22/22] Convert dwarf_expr_context_funcs to methods

Pedro Alves
2016-10-10T19:33:46Z

On 10/10/2016 07:31 PM, Pedro Alves wrote:
> On 10/09/2016 08:11 PM, Pedro Alves wrote:
>> On 09/27/2016 05:08 AM, Tom Tromey wrote:
>>> This patch converts the function pointers in dwarf_expr_context_funcs
>>> into methods on dwarf_expr_context, and then updates the various
>>> implementations and callers to follow.
>>>
>>> NB this patch uses "override" (which caught a couple of renaming bugs
>>> during development) -- but this is C++11, so this patch at least has
>>> to wait for Pedro's patch that adds the OVERRIDE macro.
>>
>> We can pull that bit in now, or remove the "override". No need to hold
>> this patch back.
>
> I remembered that I had proposed on the gcc list a while ago to
> move their OVERRIDE/FINAL macros to ansidecl.h instead, so we
> could share it. I'm testing a patch that does that.

Patch sent:

https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00654.html

Thanks,
Pedro Alves