Re: [RFA 05/22] Turn wchar iterator into a class

Pedro Alves
2016-10-06T01:01:12Z

On 09/27/2016 05:08 AM, Tom Tromey wrote:
> This changes wchar_iterator from charset.c into a real C++ class, then
> updates the users to use the class. This lets us remove some cleanups
> in favor of the class' destructor.

LGTM, assuming changed to use m_.

> +
> + /* The input string. This is updated as convert characters. */

While at it, looks like a typo here? "... as we convert ..." ?

Thanks,
Pedro Alves