Re: [RFA 15/22] Use std::string in macho_symfile_read_all_oso

Pedro Alves
2016-10-10T22:46:34Z

On 10/10/2016 11:39 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
>>> + if (strncmp (oso2->name, archive_name.c_str (), pfx_len) != 0)
>
> Pedro> Since archive_name is now a std::string, we can use ==/!= for string
> Pedro> comparison:
> Pedro> if (archive_name != oso2->name)
>
> It isn't entirely clear to me that this is valid, given that the current
> comparison is using strncmp.

Wow, I completely missed that, somehow. Sorry about that. I guess you
could use std::string::compare, but then it doesn't really make a difference.

Patch LGTM as is then.

Thanks,
Pedro Alves