Re: [RFA 19/22] Convert tid_range_parser to class

Pedro Alves
2016-10-13T01:06:52Z

On 10/12/2016 03:11 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> Here's what I ended up with, after reading your version in more
> Pedro> detail. That brought in the "deleted" copy
> Pedro> constructor/assignment operators [1], and "const" in several
> Pedro> methods, which I then propagated to number_or_range_parser too.
>
> Pedro> WDYT?
>
> I'm sorry I didn't reply to this sooner.
> This all looks good to me.

OK, I've pushed it in now. Thanks!

> Pedro> [1] - I'm pondering making those use =delete if compiling with
> Pedro> a C++ compiler, behind some
> Pedro> #define DISABLE_COPY_AND_ASSIGN(TYPE) ...
> Pedro> macro.
>
> Pedro> Or, maybe add a gdb::noncopyable class that non-copyable
> Pedro> classes inherit from privately, just like boost:noncopyable.
> Pedro> Anyone got experience on the latter, and whether that turns
> Pedro> out to be a bad idea?
>
> I haven't used that.
> The Moz approach that Trevor mentioned seems reasonable.
> Or, just switching to C++11, per the other thread, and using =delete.

Yeah.

Thanks,
Pedro Alves