From: Pedro Alves <palves@redhat.com>
To: Martin Galvan <martin.galvan@tallertechnologies.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2][PR gdb/19893] Fix handling of synthetic C++ references
Date: Tue, 24 May 2016 10:48:00 -0000 [thread overview]
Message-ID: <04d07644-c6ed-88ae-f1de-cba46e875f2d@redhat.com> (raw)
In-Reply-To: <1464019228-11131-1-git-send-email-martin.galvan@tallertechnologies.com>
Hi Martin,
This looks mostly good to me. However ...
On 05/23/2016 05:00 PM, Martin Galvan wrote:
> I've fixed a few things Pedro told me. Notice the printing of '@address' with 'set print object on'
> is not necessarily a bug (the address that'll be shown is the referenced variable's, not something
> like 0x0). If you ask me, I think we can just leave it as a (documented) corner case.
... I still don't know what to think of this -- I simply don't understand it whether
you're doing this because it makes sense, or because doing otherwise would be hard
to do?
- Can you show an example output? (set print object on/off, etc. whatever might be
handy to clearly explain that that is about).
Pictures are really worth a thousand words. :-)
- Is this covered by any testcase? I looked for "object" in the whole patch and
didn't seem to find it.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-05-24 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 16:00 Martin Galvan
2016-05-23 18:36 ` Martin Galvan
2016-05-24 10:48 ` Pedro Alves [this message]
2016-05-24 14:08 ` Martin Galvan
2016-05-24 14:51 ` Pedro Alves
2016-05-24 20:36 ` Martin Galvan
2016-05-25 18:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04d07644-c6ed-88ae-f1de-cba46e875f2d@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=martin.galvan@tallertechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox