Re: [PATCH] (dagnabbit) QNX Neutrino i386 support

Mark Kettenis
2003-05-04T09:37:44Z

"Kris Warkentin" <kewarken@qnx.com> writes:

> Well, I'd love to just be submitting a patch to all the already committed
> stuff but since you guys haven't approved my stuff yet, now I have to submit
> the whole darn thing again. Serves you right. ;-)
>
> I've gone and refactored a bunch of stuff again. I simplified the interface
> into the backend target stuff since we were doing a lot of work for
> registers that we didn't need to.

Great!

> The main (and cool) thing that I did was to take all the backend functions,
> put them into a target vector and create defines for all the functions just
> like is done in target.h and a few other places. I think it's much more
> elegant this way and it also will make it possible to create a multi-arch
> gdb for Neutrino down the road.

Thanks, very much. This is much, much better. I'm fairly certain
this work will pay off itself in the future.

Anyway, I have two further wishes, could you rename the following files:

config/tm-qnxnto.h -> config/tm-nto.h
config/i386/tm-i386nto.h -> config/i386/tm-nto.h
config/i386/i386nto.mt -> config/i386/nto.mt

This makes things a bit more consistent with recently added new
targets. Of course it requires you to make a few changes to take into
account the new names. Please make sure you change the

#include "qnxnto.h"

in config/i386/tm-nto.h into

#include "config/tm-nto.h"

otherwise you might encounter problems building GDB.

Oh and could you make the entry for configure.tgt in the ChangeLog read:

* configure.tgt: Add i[3456]86-*-nto*.

With those changes, please go ahead and check this in.

Mark