From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21457 invoked by alias); 11 Jun 2006 10:00:26 -0000 Received: (qmail 21448 invoked by uid 22791); 11 Jun 2006 10:00:26 -0000 X-Spam-Check-By: sourceware.org Received: from p12018-ipbffx02marunouchi.tokyo.ocn.ne.jp (HELO mail.pizzafactory.jp) (222.147.75.18) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 11 Jun 2006 10:00:23 +0000 Received: from [10.4.3.3] (s23.gtokyofl12.vectant.ne.jp [222.228.213.23]) by mail.pizzafactory.jp (Postfix) with ESMTP id E5BCE1F0973D; Sun, 11 Jun 2006 19:00:20 +0900 (JST) In-Reply-To: <20060610182507.GA802@nevyn.them.org> References: <0494AFF8-AB9B-40E8-A4D2-C119DEEC5248@monami-software.com> <20060519185257.GA2667@trixie.casa.cgf.cx> <20060610182507.GA802@nevyn.them.org> Mime-Version: 1.0 (Apple Message framework v750) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <04FDB127-3D41-4ACB-AE08-149DECA199F9@monami-software.com> Cc: Daniel Jacobowitz Content-Transfer-Encoding: 7bit From: Masaki Muranaka Subject: Re: [patch] Crashed cross gdb/MinGW host Date: Sun, 11 Jun 2006 10:00:00 -0000 To: gdb-patches@sourceware.org X-Mailer: Apple Mail (2.750) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00139.txt.bz2 On 2006/06/11, at 3:25, Daniel Jacobowitz wrote: > The underlying problem is actually different. The code looks like > this: (snip) > See the mismatch? :-( At that time, I didn't check consistency. I think your fix is correct. In mainline, it seems there is no path which become readfs == NULL | expectfds == NULL. So it might we have no need to check NULL. (Of course, sanity checks are always agreeable.) Thanks for your fix. -- Masaki Muranaka Monami software