From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7CC9D3858D38 for ; Thu, 16 Jul 2020 02:42:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7CC9D3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A3AD81E5F9; Wed, 15 Jul 2020 22:42:01 -0400 (EDT) Subject: Re: [ping] Re: [patch] gdb/testsuite: Fix POSIX-isms in gdb.base/shell.exp To: Sandra Loosemore , "gdb-patches@sourceware.org" , Eli Zaretskii References: <6bc2b01e-3807-77b9-7d1e-d7f6a7875e49@codesourcery.com> <164a4e8e-ddc4-d97c-75dd-377f4be35630@codesourcery.com> From: Simon Marchi Message-ID: <04837ee3-eb07-e997-b38d-d6f5ea9839ed@simark.ca> Date: Wed, 15 Jul 2020 22:41:59 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <164a4e8e-ddc4-d97c-75dd-377f4be35630@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 02:42:03 -0000 On 2020-07-15 3:53 p.m., Sandra Loosemore wrote: > Ping? I'd like to get this patch into the GDB 10 branch. > > https://sourceware.org/pipermail/gdb-patches/2020-June/169865.html > > On 6/24/20 7:35 PM, Sandra Loosemore wrote: >> This patch fixes a group of failures in gdb.base/shell.exp on Windows >> host due to assumptions that GDB is launching a POSIX-like shell.  On >> Windows, we get CMD.EXE instead. >> >> There is a potential second group of failures on Windows host not >> addressed by this patch, due to the dependence of some of these tests on >> utilities like wc, sed, and grep.  These tests happen to work for me >> because the test harness connects to the remote host using Cygwin ssh >> and both GDB and CMD.EXE inherit the PATH setting from the parent Cygwin >> shell.  I don't know if disabling those tests on Windows host too is >> appropriate, or again if this is an instance of badly-designed tests >> that could be rewritten to avoid those dependencies.  WDYT? >> >> -Sandra > The patch looks raisonnable to me... but Eli, as the de facto Windows specialist, could you give your OK? Simon