From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67045 invoked by alias); 15 Mar 2016 19:45:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66957 invoked by uid 89); 15 Mar 2016 19:45:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=2514, H*M:sk:047d7b6, H*MI:sk:047d7b6, Evans X-HELO: mail-pf0-f202.google.com Received: from mail-pf0-f202.google.com (HELO mail-pf0-f202.google.com) (209.85.192.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Mar 2016 19:45:49 +0000 Received: by mail-pf0-f202.google.com with SMTP id 4so3826947pfd.0 for ; Tue, 15 Mar 2016 12:45:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:message-id:date:subject:from:to:cc; bh=qsmvNufPQdHjRTLuXlIBZAVATeqUorC/3M8Kba7uEbI=; b=FuFsCMaBEL8BvoVOr3bs9FQ541Srjdkb25f4tZun2V6/9BVWbvU1be2zMwi55IaFB/ U/Yn2oce9XOGBYSW/FUiITQAbNhYhWcTREB8binNGO5dRVI2sJt1KdQ38oYA/3lFHQUo CfcfkhP/fMDfEJHzOF2dbDFowDFlKdhDEU6EDnEhSAWtM0ew7BYziEnEypJy27G2Un88 eCpRKhK7651tDWxVaD383XIbOWgC4GvfPPaYwUTqw9InpGz6Sb2q5MtJxuIxSt7ceukM 9FV+9Wf9EdoxW0CIrlceHl73Ww/xjlMFEDVvDhNi5QcDDgd9gpJlVqyfRJoPkrzBViqn M40A== X-Gm-Message-State: AD7BkJLiAem+7JPDPFhd/9vBIb9yM9Q0vJ9NubQyKGFfVfXOkXRSRssHLi1opzHJsreYdU1XyA== MIME-Version: 1.0 X-Received: by 10.66.163.4 with SMTP id ye4mr23922729pab.23.1458071147364; Tue, 15 Mar 2016 12:45:47 -0700 (PDT) Message-ID: <047d7b6d8462cc10a0052e1ba442@google.com> Date: Tue, 15 Mar 2016 19:45:00 -0000 Subject: Re: [PATCH, doc RFA] Add "skip regexp" From: Doug Evans To: Simon Marchi Cc: Pedro Alves , , Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00243.txt.bz2 Simon Marchi writes: > On 16-03-03 02:21 PM, Doug Evans wrote: > > 2016-03-03 Doug Evans > > > > * gdb.base/skip.c (main): Call test_skip_file_and_function. > > * gdb.base/skip.exp: Remove hand calling test_skip_file_and_function. > > > > diff --git a/gdb/testsuite/gdb.base/skip.c b/gdb/testsuite/gdb.base/skip.c > > index b9db2a7..e43da1e 100644 > > --- a/gdb/testsuite/gdb.base/skip.c > > +++ b/gdb/testsuite/gdb.base/skip.c > > @@ -25,8 +25,14 @@ void skip1_test_skip_file_and_function (void); > > int > > main () > > { > > + int x; > > + > > /* Use comma operator to sequence evaluation of bar and foo. */ > > - return baz ((bar (), foo ())); > > + x = baz ((bar (), foo ())); > > + > > + test_skip_file_and_function (); > > This function should be forward-declared. > > Otherwise, it LGTM. I tested it on the target that reported the problem initially, > and it's now 100% pass. > > Thank you very much! Committed with the suggested change.