Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 17/17] native Linux: enable always non-stop by default
Date: Mon, 18 May 2015 22:14:00 -0000	[thread overview]
Message-ID: <047d7b10c93f3cad9205166284ac@google.com> (raw)

Pedro Alves writes:
  > The testsuite shows no regressions with this forced on, on:
  >
  >  - Native x86_64 Fedora 20, with and output "set displaced off".
  >
  >  - Native x86_64 Fedora 20, on top of x86 software single-step series.
  >
  >  - PPC64 Fedora 18.
  >
  >  - S/390 RHEL 7.1.
  >
  > Let's try making it the default.
  >
  > gdb/ChangeLog:
  > 2015-04-17  Pedro Alves  <palves@redhat.com>
  >
  > 	* linux-nat.c (linux_nat_always_non_stop_p): Return 1.
  > ---
  >  gdb/linux-nat.c | 2 +-
  >  1 file changed, 1 insertion(+), 1 deletion(-)
  >
  > diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
  > index d6fd40d..51ecdbc 100644
  > --- a/gdb/linux-nat.c
  > +++ b/gdb/linux-nat.c
  > @@ -4565,7 +4565,7 @@ linux_nat_supports_non_stop (struct target_ops  
*self)
  >  static int
  >  linux_nat_always_non_stop_p (struct target_ops *self)
  >  {
  > -  return 0;
  > +  return 1;
  >  }
  >
  >  /* True if we want to support multi-process.  To be removed when GDB

Hi.
For reference I don't have any other comments on this series.

[Well, I do, but they're more higher level, and from your
notes you were planning to defer.
E.g., "I'm explictly considering changing the "set non-stop on"
behavior as out of scope here."
ref: https://sourceware.org/ml/gdb-patches/2015-04/msg00663.html
]


             reply	other threads:[~2015-05-18 22:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 22:14 Doug Evans [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-04-17 10:47 [PATCH v3 00/23] All-stop on top of non-stop Pedro Alves
2015-04-17 10:47 ` [PATCH v3 17/17] native Linux: enable always non-stop by default Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=047d7b10c93f3cad9205166284ac@google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox