From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb: make gdbarch.sh write gdbarch.{c,h} directly
Date: Sun, 24 May 2020 11:12:40 -0400 [thread overview]
Message-ID: <047c924d-ef47-b617-ae89-95f2d93ce453@simark.ca> (raw)
In-Reply-To: <aa5ae315-eb04-70ee-5f50-37b74beae14e@simark.ca>
On 2020-05-12 5:16 p.m., Simon Marchi wrote:
> On 2020-05-12 4:56 p.m., Tom Tromey wrote:
>>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Simon> It was suggested in this thread [1] that gdbarch.sh should write to
>> Simon> gdbarch.h and gdbarch.c directly. This patch implements that.
>>
>> Simon> When running gdbarch.sh, we currently need to move new-gdbarch.c over
>> Simon> gdbarch.c and new-gdbarch.h over gdbarch.h. It might have been useful
>> Simon> at some point to not have gdbarch.sh overwrite gdbarch.h and gdbarch.c,
>> Simon> but with git it's really unnecessary. Any changes to gdbarch.sh can be
>> Simon> inspected using `git diff`.
>>
>> This is a nice improvement, thanks.
>>
>> Tom
>>
>
> Thanks, I'll wait for more input for the community before pushing, in case somebody
> has an objection.
>
> Simon
>
I pushed this patch.
Simon
next prev parent reply other threads:[~2020-05-24 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 21:18 Simon Marchi
2020-05-12 20:56 ` Tom Tromey
2020-05-12 21:16 ` Simon Marchi
2020-05-24 15:12 ` Simon Marchi [this message]
2020-05-24 15:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047c924d-ef47-b617-ae89-95f2d93ce453@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox