From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-156809-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30181 invoked by alias); 16 Jun 2019 10:43:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30172 invoked by uid 89); 16 Jun 2019 10:43:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-14.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mx1.suse.de
Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Jun 2019 10:43:48 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx1.suse.de (Postfix) with ESMTP id 2DBD6ABF5;	Sun, 16 Jun 2019 10:43:46 +0000 (UTC)
Subject: [PING][PATCH][gdb] Write index for dwz -m file
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20190507144207.GA17626@delia> <90892dae-b6b9-6a89-7cee-bbed859c207b@polymtl.ca> <6cb63aac-2375-18ee-adaf-2bb9f7a0b355@suse.de> <4c7917b3-cdf0-0f17-ab6c-e76d891dfd3b@polymtl.ca>
From: Tom de Vries <tdevries@suse.de>
Message-ID: <0428a4a6-3ed8-17ee-0161-52ee12a4d941@suse.de>
Date: Sun, 16 Jun 2019 10:43:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <4c7917b3-cdf0-0f17-ab6c-e76d891dfd3b@polymtl.ca>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2019-06/txt/msg00283.txt.bz2

On 13-05-19 15:56, Simon Marchi wrote:
> On 2019-05-13 8:22 a.m., Tom de Vries wrote:
>> On 11-05-19 04:36, Simon Marchi wrote:
>>> @@ -122,12 +144,13 @@ index_cache::store (struct dwarf2_per_objfile *dwarf2_per_objfile)
>>>
>>>        if (debug_index_cache)
>>>          printf_unfiltered ("index cache: writing index cache for objfile %s\n",
>>> -			 objfile_name (obj));
>>> +			   objfile_name (obj));
>>>
>>>        /* Write the index itself to the directory, using the build id as the
>>>           filename.  */
>>
>> LGTM.
>>
>> [ I'm not sure if this white-space-only change should be included though. ]
>>
>> Thanks,
>> - Tom
> 
> Hmm probably not, but I am tempted to leave it in, since I am touching the lines around it (and it
> fixes the wrong indentation).
> 
> I will leave this patch up for review for a week or so, to give the others a chance to comment.
> 

Ping.

Thanks,
- Tom