From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aUaxE5ZOqGqjxAwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 15:44:22 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=RM0LVlIc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3E22E1E06B; Mon, 14 Sep 2026 15:44:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 353F11E051 for ; Mon, 14 Sep 2026 15:44:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 42C324BB24C5 for ; Mon, 14 Sep 2026 19:44:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42C324BB24C5 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=RM0LVlIc Received: from YQZPR01CU011.outbound.protection.outlook.com (mail-canadaeastazon11020093.outbound.protection.outlook.com [52.101.191.93]) by sourceware.org (Postfix) with ESMTPS id 8E7344B99F53 for ; Mon, 14 Sep 2026 19:43:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E7344B99F53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E7344B99F53 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.191.93 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1789415034; cv=pass; b=w2Q7sOS72o30Gafswy59Z9s9lhq7XeYHEqfS/Pf9eqeuYDGbdOPowFKp6iw8uW6TD0wAC3I9cVDbXhgfwwMcMkXkzt0cTi1s6C7CvXrj7TnkOKIVeQwfXb8qYEqEQdf870FWvSU5YduuWv/NiRg/FTjG+5bbIN1E1JHiURvfdgc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1789415034; c=relaxed/simple; bh=zHIO3cs3PSxSEnVpzNgWvi7cEhkmcdsNtKuIE7tWe8U=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=rWi6Jq5agQOzDaNz+BaNbb68oU4pF/UxC6YrFfV4R+LHrr8PoDuB4Oyp+Qo2cr1Q8XF1VKCZbEfC0rOBSTRWIYvJrjJsa055jT4w+35s6EB9B/vS4yTBMMTA829wuU53XbmPuq+Gsly6eSMFrIWv06801Qrt8MOWCxXryNswRhs= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=RM0LVlIc DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E7344B99F53 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UBuWak/w/n/NBLe4DJQUjnEqUYXGPhUWe/GKZ+ODhHT0XaQxHPw5hBS+LuLtAs/VCSWGORMqxMyb724ZkWr0o8OY9vZ74KZyajy/IO2j2/NhwaWc/rTqDChwscvKoXn4LAnxfZglTHmPwaiB0mmf4P8wyrWM1XKKJn6AsaGbpLai+e2b/Of3JQFDt3hlGskAAtopAN6PDfr/qC4yxFeNxue4WwQA97L1TZioc4z0LPz4VmZPX4Qf0qymju4H5VXWu9K+l6fdcm9xQsGEB3AE+sql6mH/O1hKzhms4cctcEH1nvyCgsHlIWyRQWzNAg8qS8mwCUlwHG59NGitHTSuTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+PoLAML6AQYt4Vk2xRgnudnOwGQ9UKkcm3Qku3cMI9U=; b=w0XZpinOk2n+Vzf2A4M0tNSTq9s9+1NJ6WiA+UiucxboF3686noQ8fPyp2NOMeUjJNHd3MOt9DcPLqXGbXqPBrjEDQNN/bBG+GzD5wz9+h6JqeEbXWpYX6WruIDR9yNjV/WZq34gROI5iEhnhBpjwABH2G6uGK7UFQ41HMz1o9vEaBfkOZ3bKNq30P6lQPXrPWXnzRctkpkkT5Ghz4gwGkfdq4E3fwHevHB15MPCca78QxWUvmI2Kcv7AbjqtxaAHk3/EIvMXiuQzkd1drKWVfHKL/fjbtTlmzz9MFveOBgZ8a8ztR77LTgmNB7stLNBNHar7kcVntZ07zJnIo2SNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+PoLAML6AQYt4Vk2xRgnudnOwGQ9UKkcm3Qku3cMI9U=; b=RM0LVlIcifSAyJm/ktOJrKELqETpjxriy6fJd8vECV8jL1EB7musglhjol1urLA3g5SQHYaDQjS83u8N0YBrwThrGgdka4nl4sOhjJnaa1fdCmTIPDhgC5WAoF4Jt19ciMvNefT7YHYjqIyOcSEpYIUl/1wf/H8fQauMNF9rgojTChfmMHbGiPGan/5FhfaTcs50tcwtUq//wEe27y4CJVpZ4RAlennS0hPunUkxn5rekv/2I5l12cP4RQPpQfMTyhKP6s2t6suJOqoiNHMtMgMhkLHG6jMfGUxmBrdsefznoHCCRbhumRhuOife3vy4RIAOnwnAYf3MjrI8cuxAxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT4PR01MB697148.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:188::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Mon, 14 Sep 2026 19:43:48 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0406.007; Mon, 14 Sep 2026 19:43:48 +0000 Message-ID: <0423d0d7-81fd-4ab1-946a-35620ec02c01@efficios.com> Date: Mon, 14 Sep 2026 15:43:47 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] gdb/python: check for nullptr before calling evpy_add_attribute To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260914191908.557014-1-simon.marchi@efficios.com> <87ik47ws9w.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87ik47ws9w.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0204.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:67::29) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT4PR01MB697148:EE_ X-MS-Office365-Filtering-Correlation-Id: d19acdc2-fe5c-4258-57a2-08df12987ea8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|23010399003|1800799024|56012099006|4143699003|10067099003|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info: VZxaJYLXrnbFG5OjbWV548RPc81+HOuYcjzPGqEWQO2oFNTfwl672TffCxkMLRRnoAC+qLJZBpkh0HacbaxBXsi+eHMswEEto9PHASBP2qc5G6aURV4DUVLLAczUj5Fp9RJ1Pe9fPDmltP1S7JSKz407yKU0aaYMedt2f44bNBvLo6nl9KzhGOkRh2LX7qmsF/uot686LIdE7XcizOZ3mO6kvYvClYa5pVk8oO6WI7UEBwfFadLii8cHfKVAZSHvTjv1/4hhsCWls/JwId7Nm/XfM0OSfC4J73lYw+jPf8HPaHXYNQBVZn00lm3re2fpko3Qme+8CRCX0PkztnFZfSkhcKsbGVGsu0BOPdyzsL3KQq8769h3c+xWwMPihQvns54IrjNKfd6lhV4jTi+z1UaybdN10mzOPSKfQYUEhSd90rkxoxnzJrdzUBdYtWnBir1hDyVaiZ4tFoUrKCmwqABzVHBOX1meObcJeiexh86OfaT4Hbvwa+eW0ATx4ItosXzmZtrCjQP4m5QbFAA6O3a8FogCLXe1k+qFDFD5gbkfurQLaS5sjk3N+T1kEM032D8W7DyCmNfnKvjR0TOfN5xTAPBp8dk/l77/L8b9hK6U1Gzk3GrlX4AV4Tg5tEUuxJnHhWe4pMxgkAJOFt6VXjpXcGG7mG0BEWxGXIvZSPc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(56012099006)(4143699003)(10067099003)(18002099003)(22082099003)(6133799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFlTM1dCVnE4NEVJamlNNk1pdTdEblpDQlpGUlUvKzNNR3IzVHVOMmEwWlVT?= =?utf-8?B?YWU5UFJucDFJWkw5WksvZFJWazF3WW5td0hSejNHZlVKVVZGTHp5VENjelBt?= =?utf-8?B?SUNLNDJPMi91QVE2Vk56a21jTllPRDFZQklyek9JMHQyWGZYY0xHZ2M4c1Vh?= =?utf-8?B?U3Fnd1RINjhwRDNJdzdHT3BGWmRDTCtuakd3bzhkNEgwRmxDZ0xuYkxPNkIv?= =?utf-8?B?M2xoWitHRWJ0YTk1S0ZKS082OEFQL3RCQTROdXdKdEZxQWNlaERwQkpoOTZn?= =?utf-8?B?WVpOTkZzTmV5cGdoNlY4TExVRlRzWElEZ0g3bEVLMkNGNUVpRDNrekJUajF6?= =?utf-8?B?Vk4wdnpSaHhCVisxcDREQmk3Wkw2NEZrRVhBRUhmUFdWY2J0eGJmaEV4VDBD?= =?utf-8?B?eEpWUTEyWk5DSHVCWDhkdnk4TUZuaHJGejlidnJNSlNBWVE1MURETVBxdGJq?= =?utf-8?B?Y3BIZ21xdDl4VDNSRjZkL2tnd2Jxc2dCQ2s2bU5zMGxMTFhlYkNTWGRTUUZU?= =?utf-8?B?VzlLZ3RoSEJjSUt6SWpLUTZocXFKaEI2VEZCc0ZUWGJwVlBlQ1lVdjh3Rmsz?= =?utf-8?B?cytua1pQN0k4Q01SSERwRSs4QUN4RG0yZG1nY3lZc0NJSEg4aG8rcmZyaE5O?= =?utf-8?B?aUM3NlpPMUpTZ200OHBocVdnVnpzYnNJaFkwbU5Ocy95aWozY1d0ejRmUmpo?= =?utf-8?B?VDZXa0JLS1l0SFBDOUluY0dIQ2RINmVVYi9xK1JRTlVtRXZ0bDRnQlFaKzRh?= =?utf-8?B?VFZNNGVZd2dZTGJzU1ZaTDlHeU00b1hNZ3V6Y1RZRTdpcGlsQ2NoaHAzaEZa?= =?utf-8?B?UHgvaSt1R0dqSjg4YkU5STlPamRUQjNDTVcwd3BxYkp0SjA2MGlZc3FvTlh2?= =?utf-8?B?NkN6SWt1c2NtY1lpUUFjRjg4NFhYaGdvYTBYV0JKZnY5WksyVlJpcThUUjd4?= =?utf-8?B?US9EN2lXM0doRVlRRXVpZlBMS3dBWGJtVnJHWGRHa3E0bFNOelRGaUhHM1Y2?= =?utf-8?B?ZjNBK0V3Y0hLM1lYYUxObHBKS2xPWVhRYktNVmx2Ui9OR2tQNjREMjhwdEFD?= =?utf-8?B?K1NSOEwxaVpzTHJVMit0akg1ZUZ0OVhmOWc0OHFwYi9qekdHclMweWlUMHh1?= =?utf-8?B?RUhKSTJoM1JNZ09WOTUyNm9OZWlJc1RCbk1rdkc3NGJab0d1dFo1NUVKNDV1?= =?utf-8?B?ek9nV3ZsU0h2WU92ZDFNUTZmeno4V05jeFFMYzllTVl6bmhLak5FMUlhVDdM?= =?utf-8?B?dWFBWTA3aTRyT1BMdlBxeWlXZVhJM2hlSUFpME1WR2NnUmFNYlB5bzhZaE5Y?= =?utf-8?B?VWo5bllUM1A3T3lwM1dRT1YvZzZwaW00OUpwS2tldGNoRGhCSUVMWmw1LzdT?= =?utf-8?B?OTFEQUdZdHpWQU1SNFNCbG15R2J6eVdLSTV2bzc4VElkZ2plTTFxQXBlTE1q?= =?utf-8?B?Y3MxTW9LL3JjakhhR29Obm9DODNaTWkyanhRaUIyL0RwL2JTYnYyNk5wY1lj?= =?utf-8?B?NmVZMUZxYUlGQXJ1WjRoMWRzQ0FpSEpqMUJRNzZNVVc3V0FOWlFqYytSWGZC?= =?utf-8?B?ZDk1Z1YyZHJ4RnJ0VlZUZXk5M3NlWVFoeUlDMDhEWVZOREFSZExneHl5YkZR?= =?utf-8?B?RHJNa0sxVjFLRlBrVG9XbVJOS3c1UnBkTVVuWlYyUDBwNGtmSTZoSHhhU3pY?= =?utf-8?B?cUxnY0JNNHc1T25uR1JmeVFhQTRialI1SENZR2h6Skx1V2VYckdKNXYzeXJu?= =?utf-8?B?eWxzQ0d0RTJ2dSt1V0lmVEtNRkZIcW9jMXJmRkozZWduZXV6aytnYldGU0E3?= =?utf-8?B?SFFpL1VXRmJjSDRsUGtrL0szNGQ2QUdPakJGRDczOGlmV2JoZ1h5MzRSdlJM?= =?utf-8?B?cVZMVHdmUUl1K096TDZPOHRSNEhNdUhmanZyWXE3VFZyWTZvdGJNSUFSWjBF?= =?utf-8?B?RGltSHNpRDFFcFZQdTd1SjJaTkFGNXF6elZEdFF6NWdPSjRWWm1xSjljY0l3?= =?utf-8?B?RUlWeFFsOTg4ajRkL2hrK3Z2MXM1bUFPN0l0TDFqQlQ2cnFLaURCaFVZZW5F?= =?utf-8?B?aGdpTWxhWVhGSjdJaW0rS0VHaStmYnRienJaYVFDNWgrM28ydHlnelh1NnVS?= =?utf-8?B?SjZic0ZmS09OczFIMDg1d2dCWjZUd1lCSUNteWFnTlYzMXMvbldlUy9LcGRp?= =?utf-8?B?VnEwK2tmMmJYVy9oWVQvcG5rMlh4ZW5URWV6My8zbFYzTk5ucU93OWM4bjIr?= =?utf-8?B?MDlRc3p3R0s0dElqdEUrSlVPSUFZOUVpNGlmVThCdE5nc0gzK2t6QlUzYkMx?= =?utf-8?B?ZHF5cElaSnFTZEsvOVhwTno1aDRpTDkrS0RqTlVhbGRkNk1GR2JhQT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: d19acdc2-fe5c-4258-57a2-08df12987ea8 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2026 19:43:48.0938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5MsBT3DzdF+MYTwbgIufhdquphYe4CGxdFAwrdQavyOF57g+R8eZvdf6Bj8xBa4lL/cAVxy4iZn8POUHPTGlfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT4PR01MB697148 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/14/26 3:24 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Found by Claude while I was reviewing some patches: gdbpy_borrowed_ref's > Simon> constructor asserts that the object is not nullptr. Some call sites can > Simon> in theory pass nullptr (although very unlikely, only on memory > Simon> allocation failure kind of errors), fix them. > > It's an oversight that these weren't already checked, and probably they > are all latent bugs. > > This is the kind of thing the safety API prevents, but (1) that's mostly > on hold pending Longo's work; and (2) we aren't really ready to switch > over the event stuff fully anyway (or at least for me it's one of the > last things to do). Ack. It's not super important, but it's also easy to fix, so why not. Simon