From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Z1vXLLFW/mlJciQAWB0awg (envelope-from ) for ; Fri, 08 May 2026 17:33:37 -0400 Received: by simark.ca (Postfix, from userid 112) id A99DA1E0BA; Fri, 08 May 2026 17:33:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DD88E1E067 for ; Fri, 08 May 2026 17:33:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7ECC74BA2E24 for ; Fri, 8 May 2026 21:33:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7ECC74BA2E24 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by sourceware.org (Postfix) with ESMTPS id 39D664BA2E07 for ; Fri, 8 May 2026 21:33:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 39D664BA2E07 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 39D664BA2E07 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778275991; cv=none; b=OkxdgHZCLyGd3c9uZBS4gfyjrBbVDSK8EYyS4+Y4/AztPm3aCMbDXlEy6WpZD0BXaLxzdPm0QcSbDN707nXIielowwqGzfY20aZkgGB6cvcUmAnGHulgyfGNNybdzFiA7NlHJ6dVCB5nzFjIv+gMsiaqf2hcvnL03qkAW4ZMfro= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778275991; c=relaxed/simple; bh=dCUWs0c88vKWmIrq7nIg832T9ETT3gZ6wIAH3pNz6DQ=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=NpfSAmCkNbssMlkTz59FZFrYltBWI9tCPqqPo6kre170wwgFHgAb3Z2jQMFhnH4DstjV5fdG4UJXK3mmOfBy4XxGNBH52B/Z22siRJyjJ9mdKyAcjKPrIF2pgy6l2OlW2MTISw2x3GyFzolZadlpxZwDb9pglGg1RIzgoYqajqA= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39D664BA2E07 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso23819665e9.2 for ; Fri, 08 May 2026 14:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778275990; x=1778880790; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o0Esz8ScLA3/8g4gkvNNtDo2vgwMkjVr8lgQL30T+4I=; b=grg0E1VNNkLEkseVI3kDvFRWLXp8oqShFLcYKZk7r7E224Hb8N9bGfPyHiNjjxDlrW XdLIhhbDraEA3WWvGDggwoQh1toWYbEm4ezmdsiVT5eU4e9b26Baco1/vJRURGzmL47p 0xNy2wk9MzLYoPv7ra5Sa2eWAOtWB0XvtdJkk5dSKkb2JdXhutDR90IxY6efrwTE/pAu YDnqjXD2VaQOAOawyvXe5UvKo1pEXttdBfenGzI6MfVf76twkCwQ+1+9wNurjU/xih6O SGrIKt5NCtNBUn4PmAxFuhSznlGiaZch663OI3Qd2p1FNa+Fif+h+G9deu4jaarnG5TO MBhA== X-Gm-Message-State: AOJu0YzowOz4aTByGn1yir2NFVhyMEko6BvZwJIuJP16iSRJwLg+EdBp BGA2pWy0ITh+vvQAxALqlAWgAHRGDP44XPJ2REKO09+0cnoXk0rkjgda X-Gm-Gg: AeBDietx9tAnz55ox1XMc2zkuCAdVp6YXGlOc/K3lc72Q/5LWPyAx+UpA2/bPy+g7pt UGDWSHoEtW1jPuRJ7+ecnP5BCujSX95l0ho37wrhB0h76sD+RrKBTSDzd/7W0SBv0VNTwFY7vS6 4t1UqWrj9HZXXjqtx+kU2zpllTK3qWzx5SqSAbCWy4kHzbLhRBm0zkfaiLC0tHURTtcjwRGc28J /NlH9NGaTVTxs29DNBCal3qpLXs/VJAaM8aLxiytinlwbfidHNtp8AA+JIEqkEn/EjcjSQ1T5bZ 1jMkC1IiH7BZG2D23qSMPNVxNkhlNHD+D3tmWJ6JpBuSjKXCeJYo74cfOkd8MkrlEhVqeMn4OYQ LlPkcvGmYN+RxWAkTFHZTrDySUsC4cujQezCPFSmTeQb5Lgb4YfDSwjXYzHXRrAC4yRPDBKKLtc xHqSy4yjZyQC7SZg47GvmPW4pGqzwdc1WrNbg1GyOwhK/U+cFVfHvruK2plS3P X-Received: by 2002:a05:600c:c094:b0:48a:599a:3716 with SMTP id 5b1f17b1804b1-48e51f40a29mr170901665e9.23.1778275989993; Fri, 08 May 2026 14:33:09 -0700 (PDT) Received: from ?IPV6:2001:8a0:facb:a800:e4b:c156:190:1fe5? ([2001:8a0:facb:a800:e4b:c156:190:1fe5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6db09a27sm8056145e9.23.2026.05.08.14.33.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 14:33:09 -0700 (PDT) Message-ID: <0418e1f0-a6e7-4acb-ac64-c2826f8afb79@palves.net> Date: Fri, 8 May 2026 22:33:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Don't pretend infcalls don't set the inferior running (PR gdb/34082) To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260423184946.1128623-1-pedro@palves.net> <87bjeqneh5.fsf@tromey.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <87bjeqneh5.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-05-08 15:49, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> I think the right fix is to stop pretending that infcalls don't set > Pedro> the target running. I can't think of a reason we do that. It really > Pedro> does run. Some thoughts: > > This makes total sense to me, and I think it's a good direction. > However, unfortunately this patch caused some regressions in > compile.exp. > > Looking at gdb.log it seems like maybe something isn't being updated on > an error path: > > compile code *(volatile int *) 0 = 0; > The program being debugged received signal SIGSEGV, Segmentation fault > while in a function called from GDB. GDB has restored the context > to what it was before the call. To change this behavior use > "set unwind-on-signal off". Evaluation of the expression containing > the function (_gdb_expr) will be abandoned. > (gdb) PASS: gdb.compile/compile.exp: compile code segfault second > break 132 > Breakpoint 2 at 0x400521: file /home/tromey/gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.compile/compile.c, line 132. > (gdb) continue > Cannot execute this command while the selected thread is running. > Bah, my build doesn't have libcc1 support: PASS: gdb.compile/compile.exp: test compile code command without running inferior PASS: gdb.compile/compile.exp: test compile command without running inferior PASS: gdb.compile/compile.exp: test compile file command without running inferior UNTESTED: gdb.compile/compile.exp: compile command not supported (could not find libcc1) I'll see if I can set that up. Also sounds like we may be missing an infcall test that exercises this case without relying on "compile". > > After this point there are several such errors. > > I'm happy to file a bug if you'd prefer. > That'd be great! I might not be able to look at this until later next week. Thanks. Pedro Alves