From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47646 invoked by alias); 23 Sep 2016 13:17:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47637 invoked by uid 89); 23 Sep 2016 13:17:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=sk:jontur, U*jon.turney, sk:jon.tur, jonturneydronecodeorguk X-HELO: out2-smtp.messagingengine.com Received: from out2-smtp.messagingengine.com (HELO out2-smtp.messagingengine.com) (66.111.4.26) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Sep 2016 13:17:45 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EA8132076B for ; Fri, 23 Sep 2016 09:17:43 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Fri, 23 Sep 2016 09:17:43 -0400 Received: from [192.168.1.102] (host86-141-129-51.range86-141.btcentralplus.com [86.141.129.51]) by mail.messagingengine.com (Postfix) with ESMTPA id 89A4ACCE9F for ; Fri, 23 Sep 2016 09:17:43 -0400 (EDT) Subject: Re: [PATCH] Consolidate target_mourn_inferior between GDB and gdbserver To: gdb-patches@sourceware.org References: <1473655918-2101-1-git-send-email-sergiodj@redhat.com> <87h99cjzd0.fsf@redhat.com> From: Jon Turney Message-ID: <03f09c13-9fec-ee9a-adf9-95e9f0e81b91@dronecode.org.uk> Date: Fri, 23 Sep 2016 13:59:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <87h99cjzd0.fsf@redhat.com> Content-Type: multipart/mixed; boundary="------------43EFCE0C54B9DA12CF7A7D23" X-SW-Source: 2016-09/txt/msg00304.txt.bz2 This is a multi-part message in MIME format. --------------43EFCE0C54B9DA12CF7A7D23 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 1070 On 19/09/2016 05:19, Sergio Durigan Junior wrote: > On Thursday, September 15 2016, Pedro Alves wrote: >> On 09/12/2016 05:51 AM, Sergio Durigan Junior wrote: >> Thanks, patch is OK. >> >>> I'd appreciate a special look at gdb/windows-nat.c's modification >>> because I wasn't really sure what to do there. It seemed to me that >>> maybe I should build a ptid out of the process information there, but >>> then I am almost sure the assertion on GDB's side would trigger. >> >> Just leave it passing inferior_ptid like all other places, which is >> a no-op. We're certain the assertion does not fail this way. > > Thanks, pushed. > > bc1e6c81d5b77d78282c47f6fd7f697e564a6eb6 This seems to miss one use of target_mourn_inferior() in windows-nat.c. > ../../gdb/windows-nat.c: In function ‘void windows_kill_inferior(target_ops*)’: > ../../gdb/windows-nat.c:2467:26: error: too few arguments to function ‘void target_mourn_inferior(ptid_t)’ > target_mourn_inferior (); /* Or just windows_mourn_inferior? */ > ^ Patch attached. --------------43EFCE0C54B9DA12CF7A7D23 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-a-use-of-target_mourn_inferior-in-windows-nat.c.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Fix-a-use-of-target_mourn_inferior-in-windows-nat.c.pat"; filename*1="ch" Content-length: 1981 RnJvbSA3NTg2OWNmNTM5MDU2YmNmZjIzNTFmNjk4Y2NmNzkyODZkMTM3Y2Zi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxq b24udHVybmV5QGRyb25lY29kZS5vcmcudWs+CkRhdGU6IEZyaSwgMjMgU2Vw IDIwMTYgMTQ6MDc6NTUgKzAxMDAKU3ViamVjdDogW1BBVENIXSBGaXggYSB1 c2Ugb2YgdGFyZ2V0X21vdXJuX2luZmVyaW9yIGluIHdpbmRvd3MtbmF0LmMK Ck9uZSB1c2Ugb2YgdGFyZ2V0X21vdXJuX2ludGVyaW9yIHNlZW1zIHRvIGhh dmUgYmVlbiBtaXNzZWQgaW4gYmMxZTZjODEKCmdkYi9DaGFuZ2VMb2c6Cgoy MDE2LTA5LTIzICBKb24gVHVybmV5ICA8am9uLnR1cm5leUBkcm9uZWNvZGUu b3JnLnVrPgoKCSogd2luZG93cy1uYXQuYyAod2luZG93c19kZWxldGVfdGhy ZWFkKTogQWRqdXN0aW5nIGNhbGwgdG8KCXRhcmdldF9tb3Vybl9pbmZlcmlv ciB0byBpbmNsdWRlIHB0aWRfdCBhcmd1bWVudC4KClNpZ25lZC1vZmYtYnk6 IEpvbiBUdXJuZXkgPGpvbi50dXJuZXlAZHJvbmVjb2RlLm9yZy51az4KLS0t CiBnZGIvQ2hhbmdlTG9nICAgICB8IDUgKysrKysKIGdkYi93aW5kb3dzLW5h dC5jIHwgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvQ2hhbmdlTG9nIGIv Z2RiL0NoYW5nZUxvZwppbmRleCBlYTE0ZjA0Li5jN2ExOTRmIDEwMDY0NAot LS0gYS9nZGIvQ2hhbmdlTG9nCisrKyBiL2dkYi9DaGFuZ2VMb2cKQEAgLTEs MyArMSw4IEBACisyMDE2LTA5LTIzICBKb24gVHVybmV5ICA8am9uLnR1cm5l eUBkcm9uZWNvZGUub3JnLnVrPgorCisJKiB3aW5kb3dzLW5hdC5jICh3aW5k b3dzX2RlbGV0ZV90aHJlYWQpOiBBZGp1c3RpbmcgY2FsbCB0bworCXRhcmdl dF9tb3Vybl9pbmZlcmlvciB0byBpbmNsdWRlIHB0aWRfdCBhcmd1bWVudC4K KwogMjAxNi0wOS0yMiAgRWRqdW5pb3IgQmFyYm9zYSBNYWNoYWRvICA8ZW1h Y2hhZG9AbGludXgudm5ldC5pYm0uY29tPgogCiAJKiByczYwMDAtdGRlcC5j IChwcGNfcHJvY2Vzc19yZWNvcmRfb3AzMSk6IEZpeApkaWZmIC0tZ2l0IGEv Z2RiL3dpbmRvd3MtbmF0LmMgYi9nZGIvd2luZG93cy1uYXQuYwppbmRleCAz MWE5ZWNiLi5jNmE4MDliIDEwMDY0NAotLS0gYS9nZGIvd2luZG93cy1uYXQu YworKysgYi9nZGIvd2luZG93cy1uYXQuYwpAQCAtMjQ2NCw3ICsyNDY0LDcg QEAgd2luZG93c19raWxsX2luZmVyaW9yIChzdHJ1Y3QgdGFyZ2V0X29wcyAq b3BzKQogCWJyZWFrOwogICAgIH0KIAotICB0YXJnZXRfbW91cm5faW5mZXJp b3IgKCk7CS8qIE9yIGp1c3Qgd2luZG93c19tb3Vybl9pbmZlcmlvcj8gICov CisgIHRhcmdldF9tb3Vybl9pbmZlcmlvciAoaW5mZXJpb3JfcHRpZCk7CS8q IE9yIGp1c3Qgd2luZG93c19tb3Vybl9pbmZlcmlvcj8gICovCiB9CiAKIHN0 YXRpYyB2b2lkCi0tIAoyLjguMwoK --------------43EFCE0C54B9DA12CF7A7D23--