From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-153905-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20383 invoked by alias); 13 Feb 2019 11:40:11 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20373 invoked by uid 89); 13 Feb 2019 11:40:10 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=
X-HELO: mail-wr1-f66.google.com
Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Feb 2019 11:40:09 +0000
Received: by mail-wr1-f66.google.com with SMTP id v13so2104382wrw.5        for <gdb-patches@sourceware.org>; Wed, 13 Feb 2019 03:40:09 -0800 (PST)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:75e6:857f:3506:a1f4? ([2001:8a0:f913:f700:75e6:857f:3506:a1f4])        by smtp.gmail.com with ESMTPSA id j5sm1663264wrw.59.2019.02.13.03.40.05        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Wed, 13 Feb 2019 03:40:06 -0800 (PST)
Subject: Re: [PING][PATCH v2 PR gdb/21870] aarch64: Leftover uncleared debug registers
To: Weimin Pan <weimin.pan@oracle.com>, Alan Hayward <Alan.Hayward@arm.com>
References: <1530148222-12558-1-git-send-email-weimin.pan@oracle.com> <145f2e8d-4321-00a6-650a-bf8f0a483b6f@oracle.com> <e85c8cef-36d1-44e5-40c8-0768392df74e@oracle.com> <7861E9FA-0293-4C16-857A-6935579C7042@arm.com> <fa84d562-4413-c388-a363-25f50949b91d@oracle.com> <BD80459D-D6EB-47D3-9B25-CE284A83954F@arm.com> <3eea53e4-dfc6-ef59-f88f-d35797c26ba6@oracle.com> <31396591-A287-40C5-A4D0-6EAEC8077D6B@arm.com> <563997a0-cd3c-cf6e-8418-bbd452436b2b@oracle.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, nd <nd@arm.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <037877d7-a3d3-7ae1-cafa-0bd29927abb2@redhat.com>
Date: Wed, 13 Feb 2019 11:40:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <563997a0-cd3c-cf6e-8418-bbd452436b2b@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-02/txt/msg00172.txt.bz2

On 02/12/2019 01:10 AM, Weimin Pan wrote:
> +clean_restart $testfile
> +
> +set test "run to exit"
> +gdb_test_multiple "run" "$test" {
> +    -re "exited with code 01.*$gdb_prompt $" {
> +        pass "$test"
> +    }
> +    -re "exited normally.*$gdb_prompt $" {
> +        pass "$test"
> +    }
> +}

A naked "run" command doesn't work when testing against
gdbserver with --target_board=native-gdbserver.

Is "run" important here?  Could this use runto_main + "continue" instead?

Also, the comment at the top of the file says:

 # This test checks that GDB does not alter watchpoints set by an inferior.
 # It sets a watchpoint on memory then writes to the watched memory.
 # It will exit with 1 if the watchpoint is not reached.

But I couldn't spot where that "exit with 1" happens in the .c file.
Also, when that happens, we're issuing a pass, as seen above.
Is that intended?

Thanks,
Pedro Alves