From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26938 invoked by alias); 19 Mar 2014 15:35:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26921 invoked by uid 89); 19 Mar 2014 15:35:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Mar 2014 15:35:39 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 19 Mar 2014 08:32:14 -0700 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 19 Mar 2014 08:31:32 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.87]) by IRSMSX104.ger.corp.intel.com ([169.254.5.224]) with mapi id 14.03.0123.003; Wed, 19 Mar 2014 15:31:08 +0000 From: "Agovic, Sanimir" To: 'Joel Brobecker' CC: "tromey@redhat.com" , "Boell, Keven" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence Date: Wed, 19 Mar 2014 15:35:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A71774667B@IRSMSX105.ger.corp.intel.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> <1391704056-25246-10-git-send-email-sanimir.agovic@intel.com> <20140228170941.GB16479@adacore.com> <20140313160055.GI4882@adacore.com> In-Reply-To: <20140313160055.GI4882@adacore.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00449.txt.bz2 Thanks for your review. > I see. It took me a while to understand what you are saying, but > I do, now. It's one of these situations where it's almost a shame > that some case branches return, while others don't, and fallback > on something that happens to take care of dynamicity. Oh well, I have > no better proposal at the moment, so the current approach is fine > with me. >=20 > Question for you: Shouldn't we be doing the same for LOC_CONST? >=20 Good catch, indeed we should. I have updated the patch to cover LOC_CONST and added a test-case as well. Thanks again. -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052