From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5702 invoked by alias); 12 Mar 2014 13:51:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5685 invoked by uid 89); 12 Mar 2014 13:51:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga03.intel.com Received: from Unknown (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Mar 2014 13:51:37 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by azsmga101.ch.intel.com with ESMTP; 12 Mar 2014 06:51:34 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 12 Mar 2014 06:51:22 -0700 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 12 Mar 2014 13:51:02 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.62]) by IRSMSX151.ger.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0123.003; Wed, 12 Mar 2014 13:51:02 +0000 From: "Agovic, Sanimir" To: 'Joel Brobecker' CC: "tromey@redhat.com" , "Boell, Keven" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 08/15] vla: support for DW_AT_count Date: Wed, 12 Mar 2014 13:51:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A717734174@IRSMSX105.ger.corp.intel.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> <1391704056-25246-9-git-send-email-sanimir.agovic@intel.com> <20140228165300.GA16479@adacore.com> In-Reply-To: <20140228165300.GA16479@adacore.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00292.txt.bz2 Thanks for your review. > Overall, the patch looks OK to me, but I'd rather we be consistent > with what we've been doing with other type flags, and use a bitfield > instead. I think that'll simplify your patch a bit. >=20 I`m using bitfields now but they are still part of the struct range_bounds and not struct main_type as they are specific to arrays and not types in general. -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052