From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28648 invoked by alias); 12 Mar 2014 12:53:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28635 invoked by uid 89); 12 Mar 2014 12:52:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Mar 2014 12:52:56 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 12 Mar 2014 05:52:35 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 12 Mar 2014 05:52:10 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.62]) by IRSMSX103.ger.corp.intel.com ([169.254.3.84]) with mapi id 14.03.0123.003; Wed, 12 Mar 2014 12:52:10 +0000 From: "Agovic, Sanimir" To: 'Joel Brobecker' CC: "tromey@redhat.com" , "Boell, Keven" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 15/15] test: add mi vla test Date: Wed, 12 Mar 2014 12:53:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A7177340D1@IRSMSX105.ger.corp.intel.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> <1391704056-25246-16-git-send-email-sanimir.agovic@intel.com> <20140228180716.GH16479@adacore.com> In-Reply-To: <20140228180716.GH16479@adacore.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00286.txt.bz2 Thanks for your review. I addressed all issues in the series dealing with tests. https://sourceware.org/ml/gdb-patches/2014-02/msg00874.html https://sourceware.org/ml/gdb-patches/2014-02/msg00873.html https://sourceware.org/ml/gdb-patches/2014-02/msg00872.html https://sourceware.org/ml/gdb-patches/2014-02/msg00871.html -Sanimir > -----Original Message----- > From: Joel Brobecker [mailto:brobecker@adacore.com] > Sent: Friday, February 28, 2014 07:07 PM > To: Agovic, Sanimir > Cc: tromey@redhat.com; Boell, Keven; gdb-patches@sourceware.org > Subject: Re: [PATCH v5 15/15] test: add mi vla test >=20 > On Thu, Feb 06, 2014 at 05:27:36PM +0100, Sanimir Agovic wrote: > > 2013-10-18 Keven Boell > > Sanimir Agovic > > > > testsuite/gdb.mi/ > > > > * mi-vla-c99.exp: New file. > > * vla.c: New file. >=20 > Some minor comments as before - pre-approved with those changes. >=20 > > Signed-off-by: Sanimir Agovic > > --- > > gdb/testsuite/gdb.mi/mi-vla-c99.exp | 82 +++++++++++++++++++++++++++++= ++++++++ > > gdb/testsuite/gdb.mi/vla.c | 35 ++++++++++++++++ > > 2 files changed, 117 insertions(+) > > create mode 100644 gdb/testsuite/gdb.mi/mi-vla-c99.exp > > create mode 100644 gdb/testsuite/gdb.mi/vla.c > > > > diff --git a/gdb/testsuite/gdb.mi/mi-vla-c99.exp b/gdb/testsuite/gdb.mi= /mi-vla-c99.exp > > new file mode 100644 > > index 0000000..9d0c6cc > > --- /dev/null > > +++ b/gdb/testsuite/gdb.mi/mi-vla-c99.exp > > @@ -0,0 +1,82 @@ > > +# Copyright 1999-2013 Free Software Foundation, Inc. >=20 > Copyright year range. >=20 > > + > > +# Contributed by Intel Corp. > > +# > > +# This program is free software; you can redistribute it and/or modify > > +# it under the terms of the GNU General Public License as published by > > +# the Free Software Foundation; either version 3 of the License, or > > +# (at your option) any later version. > > +# > > +# This program is distributed in the hope that it will be useful, > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > +# GNU General Public License for more details. > > +# > > +# You should have received a copy of the GNU General Public License > > +# along with this program. If not, see . > > + > > +# Verify that, using the MI, we can evaluate a simple C Variable Length > > +# Array (VLA). > > + > > +load_lib mi-support.exp > > +set MIFLAGS "-i=3Dmi" > > + > > +gdb_exit > > +if [mi_gdb_start] { > > + continue > > +} > > + > > +standard_testfile vla.c > > + > > +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" \ > > + "${binfile}" executable {debug}] !=3D "" } { > > + untested mi-vla-basics.exp > > + return -1 > > +} > > + > > +mi_delete_breakpoints > > +mi_gdb_reinitialize_dir $srcdir/$subdir > > +mi_gdb_load ${binfile} > > + > > +set bp_lineno [gdb_get_line_number "vla-filled"] > > + > > +mi_create_breakpoint "-t vla.c:$bp_lineno" 1 "del" "func" \ > > + ".*vla.c" $bp_lineno $hex \ > > + "insert breakpoint at line $bp_lineno after vla is filled" > > +mi_run_cmd > > +mi_expect_stop "breakpoint-hit" "func" "\{name=3D\"n\",value=3D\"5\"\}= " \ > > + ".*vla.c" "$bp_lineno" { "" "disp=3D\"del\"" } \ > > + "run to breakpoint at line $bp_lineno" > > + > > +mi_gdb_test "500-data-evaluate-expression vla" \ > > + "500\\^done,value=3D\"\\{0, 1, 2, 3, 4\\}\"" "evaluate complete vl= a" > > + > > +mi_gdb_test "501-data-evaluate-expression vla\[0\]" \ > > + "501\\^done,value=3D\"0\"" "evaluate vla\[0\]" > > + > > +mi_gdb_test "502-data-evaluate-expression vla\[2\]" \ > > + "502\\^done,value=3D\"2\"" "evaluate vla\[2\]" > > + > > +mi_gdb_test "503-data-evaluate-expression vla\[4\]" \ > > + "503\\^done,value=3D\"4\"" "evaluate vla\[4\]" > > + > > +mi_create_varobj_checked vla vla "int \\\[5\\\]" \ > > + "create local variable vla" > > + > > +mi_gdb_test "504-var-info-type vla" \ > > + "504\\^done,type=3D\"int \\\[5\\\]\"" \ > > + "info type variable vla" > > + > > +mi_gdb_test "505-var-show-format vla" \ > > + "505\\^done,format=3D\"natural\"" \ > > + "show format variable vla" > > + > > +mi_gdb_test "506-var-evaluate-expression vla" \ > > + "506\\^done,value=3D\"\\\[5\\\]\"" \ > > + "eval variable vla" > > + > > +mi_list_array_varobj_children "vla" "5" "int" \ > > + "get children of vla" > > + > > +mi_gdb_exit > > +return 0 > > diff --git a/gdb/testsuite/gdb.mi/vla.c b/gdb/testsuite/gdb.mi/vla.c > > new file mode 100644 > > index 0000000..9b33fc8 > > --- /dev/null > > +++ b/gdb/testsuite/gdb.mi/vla.c > > @@ -0,0 +1,35 @@ > > +/* This testcase is part of GDB, the GNU debugger. > > + > > + Contributed by Intel Corp. > > + > > + Copyright 2013 Free Software Foundation, Inc. >=20 > Copyright year range... >=20 > > + > > + This program is free software; you can redistribute it and/or modify > > + it under the terms of the GNU General Public License as published by > > + the Free Software Foundation; either version 3 of the License, or > > + (at your option) any later version. > > + > > + This program is distributed in the hope that it will be useful, > > + but WITHOUT ANY WARRANTY; without even the implied warranty of > > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + GNU General Public License for more details. > > + > > + You should have received a copy of the GNU General Public License > > + along with this program. If not, see . */ > > + > > +int func (int n) >=20 > Formatting: >=20 > int > func (int n) >=20 > > +{ > > + int vla[n], i; > > + > > + for (i =3D 0; i < n; i++) > > + vla[i] =3D i; > > + > > + return n; /* vla-filled */ > > +} > > + > > +int main () >=20 > Rewrite: >=20 > int > main (void) >=20 > > +{ > > + func (5); > > + > > + return 0; > > +} > > -- > > 1.8.4.2 >=20 > -- > Joel Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052